Skip to content

Conversation

@zephyrbot
Copy link

@zephyrbot zephyrbot commented Dec 18, 2024

Backport 01fc0a7~6..01fc0a7 from #82991.

Fixes #83148

Keep a consistent order on the nodes definitions to make it easy to read
between all the SoC series.

Signed-off-by: Gerson Fernando Budke <[email protected]>
(cherry picked from commit 6f1f598)
When running tests on sam0 platform was detected that pinctrl for ADC
were not defined for some boards. To force an error at build time
nodes should be explicity disabled. This explicity disable nodes on
devicetree that require some user configuration.

In addition, the adc feature were excluded in some boards and
samr21-xpro was correct updated.

Signed-off-by: Gerson Fernando Budke <[email protected]>
(cherry picked from commit 162f728)
Reorder and add missing aliases and chosen nodes.

Signed-off-by: Gerson Fernando Budke <[email protected]>
(cherry picked from commit 748bbd0)
The DMA is already defined on the base header. This exclude the
duplicated node.

Signed-off-by: Gerson Fernando Budke <[email protected]>
(cherry picked from commit 2e7599e)
The saml2x series provide USB to all SoC series. This moves the USB node
from saml21.dtsi to the base file saml2x.dtsi.

Signed-off-by: Gerson Fernando Budke <[email protected]>
(cherry picked from commit 34fc01e)
The samr21 is a samd21 with a builtin at86rf233 radio. Use the samd21 as
base for these SoC and drop all duplicated nodes.

Signed-off-by: Gerson Fernando Budke <[email protected]>
(cherry picked from commit 01fc0a7)
@zephyrbot zephyrbot requested a review from galak as a code owner December 18, 2024 00:01
@zephyrbot zephyrbot added the Backport Backport PR and backport failure issues label Dec 18, 2024
@zephyrbot zephyrbot requested a review from nandojve as a code owner December 18, 2024 00:01
@zephyrbot zephyrbot added the platform: Microchip SAM Microchip SAM Platform (formerly Atmel SAM) label Dec 18, 2024
@nandojve nandojve linked an issue Dec 18, 2024 that may be closed by this pull request
@fabiobaltieri
Copy link
Member

Is this a valid backport though? The idea was to only backpor bugfixes, this is clearly a cleanup.

@pdgendt
Copy link
Contributor

pdgendt commented Dec 24, 2024

Is this a valid backport though? The idea was to only backpor bugfixes, this is clearly a cleanup.

The same #83135 (comment)

@nandojve
Copy link
Member

Is this a valid backport though? The idea was to only backpor bugfixes, this is clearly a cleanup.

People have been struggling to backport OOT code, which is a long term problem. Due to heavily changes on dts I'm not sure if future fixes/backports will be easy/possible to backport without these changes. I just want to make sure future enhancements are easy to developers to backport.

@fabiobaltieri
Copy link
Member

People have been struggling to backport OOT code, which is a long term problem. Due to heavily changes on dts I'm not sure if future fixes/backports will be easy/possible to backport without these changes. I just want to make sure future enhancements are easy to developers to backport.

Fair enough, that's an interesting data point actually since on the process side there's some talk about maintaining multiple lts releases for 5 years or something.

@dkalowsk dkalowsk added this to the v3.7.1 milestone Dec 27, 2024
Copy link
Member

@nashif nashif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not a fix for a bug and does not qualify for backporting.

@fabiobaltieri fabiobaltieri modified the milestones: v3.7.1, v3.7.2 Feb 17, 2025
@nashif
Copy link
Member

nashif commented Apr 14, 2025

closing as stale

@nashif nashif closed this Apr 14, 2025
@github-project-automation github-project-automation bot moved this from To do to Done in Backports Apr 14, 2025
@nashif nashif deleted the backport-82991-to-v3.7-branch branch April 14, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport Backport PR and backport failure issues platform: Microchip SAM Microchip SAM Platform (formerly Atmel SAM)

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

dts: atmel: sam0: Clean up devicetree

9 participants