treewide: Use hyphens instead of underscores for property separation #83352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have a lot of work to catch up on right now, like CI checks and other underlying changes (maybe due to a lack of focus). |
rruuaanng
force-pushed
the
bindings-style
branch
8 times, most recently
from
f765f9a to
debb691
Compare
|
I wrote another PR which adds the devicetree coding style to the contributor guide. |
zephyrbot
requested review from
DerekSnell,
EmilioCBen,
VenkatKotakonda,
aaillet,
albertofloyd,
butok,
dbaluta,
decsny,
dleach02,
jvasanth1,
lorc,
manuargue,
mmahadevan108,
xakep-amatop and
yvanderv
rruuaanng
force-pushed
the
bindings-style
branch
2 times, most recently
from
95e3358 to
502e60a
Compare
JarmouniA
previously approved these changes
Jun 12, 2025
rruuaanng
force-pushed
the
bindings-style
branch
from
502e60a to
0e48b58
Compare
This script replaces all underscore(_) separation in a binding with hyphens(-). Signed-off-by: James Roy <[email protected]>
rruuaanng
force-pushed
the
bindings-style
branch
from
0e48b58 to
a5aab42
Compare
rruuaanng
force-pushed
the
bindings-style
branch
from
a5aab42 to
ffc9085
Compare
Implement a check in the CI pipeline to enforce that property names in device tree bindings do not contain underscores. Signed-off-by: James Roy <[email protected]> Signed-off-by: Martí Bolívar <[email protected]>
Bindings now use hyphens(-) instead of underscores(_) as property separators. Signed-off-by: James Roy <[email protected]>
rruuaanng
force-pushed
the
bindings-style
branch
from
ffc9085 to
5daa5d7
Compare
|
cfriedt
approved these changes
Jun 13, 2025
JarmouniA
approved these changes
Jun 13, 2025
henrikbrixandersen
approved these changes
Jun 17, 2025
maass-hamburg
added a commit
to maass-hamburg/zephyr
that referenced
this pull request
Jun 18, 2025
in zephyrproject-rtos#83352 a few bindings were not migrated, fix that, as it will lead to ci fails. Signed-off-by: Fin Maaß <[email protected]>
|
@rruuaanng some props were not migrated and are now causing ci fails, when dts yamls are changed, fix: #91818 |
maass-hamburg
added a commit
to maass-hamburg/zephyr
that referenced
this pull request
Jun 18, 2025
in zephyrproject-rtos#83352 a few bindings were not migrated, fix that, as it will lead to ci fails. Signed-off-by: Fin Maaß <[email protected]>
nashif
pushed a commit
that referenced
this pull request
Jun 18, 2025
in #83352 a few bindings were not migrated, fix that, as it will lead to ci fails. Signed-off-by: Fin Maaß <[email protected]>
Chenhongren
pushed a commit
to Chenhongren/zephyr
that referenced
this pull request
Jul 23, 2025
in zephyrproject-rtos#83352 a few bindings were not migrated, fix that, as it will lead to ci fails. (cherry picked from commit 4a468e9) Original-Signed-off-by: Fin Maaß <[email protected]> GitOrigin-RevId: 4a468e9 Cr-Build-Id: 8711682253588645601 Cr-Build-Url: https://cr-buildbucket.appspot.com/build/8711682253588645601 Copybot-Job-Name: zephyr-main-copybot-downstream Change-Id: I3e9a931b19c8edb7358a85c93bf8950d95ae253b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/6655868 Tested-by: Keith Short <[email protected]> Commit-Queue: Keith Short <[email protected]> Reviewed-by: Yuval Peress <[email protected]> Tested-by: Yuval Peress <[email protected]> Reviewed-by: Keith Short <[email protected]> Tested-by: ChromeOS Copybot <[email protected]>
bjda
pushed a commit
to bjda/zephyr
that referenced
this pull request
Sep 5, 2025
in zephyrproject-rtos#83352 a few bindings were not migrated, fix that, as it will lead to ci fails. Signed-off-by: Fin Maaß <[email protected]> (cherry picked from commit 4a468e9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This inherits from proposal #53502, with the main work as shown in the title. For details, see #53506.
Closes: #83741