Skip to content

Conversation

@mmahadevan108
Copy link
Contributor

@mmahadevan108 mmahadevan108 commented Jan 10, 2025

Some NXP SoC's have External cache that is managed by the XCACHE cache controller. This should fix build failures seen with #83703

Fixes #83703

@zephyrbot
Copy link

zephyrbot commented Jan 10, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_nxp zephyrproject-rtos/hal_nxp@7d1c795 zephyrproject-rtos/hal_nxp@c15dd51 (master) zephyrproject-rtos/[email protected]

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added manifest manifest-hal_nxp DNM This PR should not be merged (Do Not Merge) labels Jan 10, 2025
@mmahadevan108
Copy link
Contributor Author

@lucien-nxp FYI about this PR.

decsny
decsny previously approved these changes Jan 13, 2025
hakehuang
hakehuang previously approved these changes Jan 14, 2025
Copy link
Contributor

@hakehuang hakehuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regression board testing pass

Copy link
Member

@dleach02 dleach02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but needs to be sequenced behind #83883

@mmahadevan108 I merged the HAL side so please update your PR to point to the new SHA. When the gating PR merges I'll clear my CR

@mmahadevan108 mmahadevan108 dismissed stale reviews from hakehuang and decsny via ba7cca4 January 14, 2025 22:02
@zephyrbot zephyrbot removed the DNM This PR should not be merged (Do Not Merge) label Jan 14, 2025
Some NXP SoC's have External cache that is managed by
the XCACHE cache controller.

Signed-off-by: Mahesh Mahadevan <[email protected]>
This Kconfig is used to pull in the XCACHE SDK driver

Signed-off-by: Mahesh Mahadevan <[email protected]>
The CM33 has a XCACHE controller to manage the External
cache. Remove unused Kconfigs as we can use Zephyr API's
to manage the CM33 cache,

Signed-off-by: Mahesh Mahadevan <[email protected]>
@mmahadevan108
Copy link
Contributor Author

@carlocaione , can you help review this PR.

Copy link
Member

@dleach02 dleach02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gating PR merged

@dleach02 dleach02 added the bug The issue is a bug, or the PR is fixing a bug label Jan 15, 2025
@mmahadevan108
Copy link
Contributor Author

@carlocaione , this PR is fixing CI failures that are gating a few other PR's. Could you help review

@dleach02 dleach02 self-assigned this Jan 15, 2025
@decsny decsny added the Hotfix Fix for issues blocking development, i.e. upstream CI issues, tests failing in upstream CI , etc. label Jan 15, 2025
@kartben kartben merged commit 9f31feb into zephyrproject-rtos:main Jan 15, 2025
31 checks passed
@mmahadevan108 mmahadevan108 deleted the Add_XCACHE_Support branch January 15, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Cache bug The issue is a bug, or the PR is fixing a bug Hotfix Fix for issues blocking development, i.e. upstream CI issues, tests failing in upstream CI , etc. manifest manifest-hal_nxp platform: NXP Drivers NXP Semiconductors, drivers platform: NXP NXP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants