Skip to content

boards: raspberrypi: rpi_pico2: enable wdt0 #85005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 7, 2025
Merged

boards: raspberrypi: rpi_pico2: enable wdt0 #85005

merged 3 commits into from
Mar 7, 2025

Conversation

soburi
Copy link
Member

@soburi soburi commented Feb 1, 2025 •
edited by kartben
Loading

Enables the watchdog timer to match the rpi_pico's configuration.

Also includes a minor cleanup of related code.

We need to solve #84974 first.

@soburi soburi added the platform: Raspberry Pi Pico Raspberry Pi Pico (RPi Pico) label Feb 1, 2025
@soburi soburi marked this pull request as ready for review February 1, 2025 02:08
@soburi soburi added the DNM This PR should not be merged (Do Not Merge) label Feb 1, 2025
@ajf58
Copy link
Contributor

ajf58 commented Feb 1, 2025

313dfa2 and 418fa6d should be in one commit.

In the current sequence you've broken the build in 313dfa2, then fixed it in 418fa6d .

@soburi
Copy link
Member Author

soburi commented Feb 1, 2025

313dfa2 and 418fa6d should be in one commit.

In the current sequence you've broken the build in 313dfa2, then fixed it in 418fa6d .

This shouldn't happen since 313dfa2 is the most recent commit.

@ajf58
Copy link
Contributor

ajf58 commented Feb 1, 2025 •
edited
Loading

313dfa2 and 418fa6d should be in one commit.
In the current sequence you've broken the build in 313dfa2, then fixed it in 418fa6d .

This shouldn't happen since 313dfa2 is the most recent commit.

Not according to https://github.com/zephyrproject-rtos/zephyr/pull/85005/commits .

I'm sorry, I was wrong: I misread the commit log. I still think it'd be good to squash these together, but it was incorrect of me to think this caused a broken state.

@soburi soburi added DNM (manifest) This PR should not be merged (controlled by action-manifest) DNM This PR should not be merged (Do Not Merge) and removed DNM This PR should not be merged (Do Not Merge) DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Feb 5, 2025
@soburi soburi added this to the v4.1.0 milestone Feb 7, 2025
@soburi
boards: raspberrypi: rpi_pico2: enable wdt0
6e1ef1f 
Enables the watchdog timer to align with the rpi_pico's setting.

Signed-off-by: TOKITA Hiroshi <[email protected]>
@soburi
drivers: clock_control: Calling tick_start directly to start wdt
c4ede58 
`watchdog_start_tick` is a just wrapper for `tick_start`.
To simplify, changing it to call directly.

Signed-off-by: TOKITA Hiroshi <[email protected]>
@soburi
pico-sdk: Exclude the watchdog driver.
6b18446 
Review the dependencies to make it unnecessary to pull in the
watchdog driver.

Signed-off-by: TOKITA Hiroshi <[email protected]>
@soburi soburi removed the DNM This PR should not be merged (Do Not Merge) label Feb 11, 2025
@kartben kartben requested a review from ajf58 February 14, 2025 03:04
kartben
kartben approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating the list of supported features in the board documentation would be nice but with #85652 around the corner I think I can live with that :)

ajf58
ajf58 approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@ajf58 ajf58 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, passes test under Twister.

I agree with @kartben about the documentation issue on both fronts.

@soburi
Copy link
Member Author

soburi commented Feb 14, 2025

Yes, I will update it accordingly once #85652 is merged.

@soburi
Copy link
Member Author

soburi commented Feb 14, 2025 •
edited
Loading

@nordic-krch @ThreeEights

I'm very sorry, but could you please take a look at it?

@soburi soburi removed this from the v4.1.0 milestone Feb 17, 2025
@kartben kartben added this to the v4.2.0 milestone Feb 17, 2025
@ajf58 ajf58 mentioned this pull request Feb 23, 2025
Closed
@carlescufi carlescufi merged commit 1d543de into zephyrproject-rtos:main Mar 7, 2025
24 of 25 checks passed
@soburi soburi deleted the pico2_enable_wdt branch March 7, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kartben kartben kartben approved these changes

@ajf58 ajf58 ajf58 approved these changes

@nordic-krch nordic-krch nordic-krch approved these changes

@ThreeEights ThreeEights Awaiting requested review from ThreeEights

@yonsch yonsch Awaiting requested review from yonsch

Assignees

@soburi soburi

Labels

area: Clock Control platform: Raspberry Pi Pico Raspberry Pi Pico (RPi Pico)

Projects

None yet

Milestone

v4.2.0

Development

Successfully merging this pull request may close these issues.

6 participants

@soburi @ajf58 @kartben @nordic-krch @carlescufi @zephyrbot