Skip to content

Conversation

@jpanisbl
Copy link
Contributor

@jpanisbl jpanisbl commented Feb 4, 2025

This ensures board shows up nicely in docs and search.

Implement the changes requested by @kartben : #76441 (review)

@jpanisbl jpanisbl force-pushed the baylibre/upstream-cc23x0-doc-fix branch from d78c94e to 444df49 Compare February 4, 2025 15:01
@jpanisbl
Copy link
Contributor Author

jpanisbl commented Feb 4, 2025

@kartben I implemented the changes you requested but the CI fails it seems:
Key 'full_name' was not defined. Path: '/board/socs/1'.: Path: '/'>

Should I finally remove this line ?

[UPDATE] Actually I found the issue. full_name is not exactly where it should -> Fixed now

This ensures board shows up nicely in docs and search.

Signed-off-by: Julien Panis <[email protected]>
@jpanisbl jpanisbl force-pushed the baylibre/upstream-cc23x0-doc-fix branch from 444df49 to 9c6a6c5 Compare February 4, 2025 15:15
@kartben
Copy link
Contributor

kartben commented Feb 4, 2025

@kartben I implemented the changes you requested but the CI fails it seems: Key 'full_name' was not defined. Path: '/board/socs/1'.: Path: '/'>

Should I finally remove this line ?

[UPDATE] Actually I found the issue. full_name is not exactly where it should -> Fixed now

yep exactly :) Thanks!

@jpanisbl
Copy link
Contributor Author

jpanisbl commented Feb 4, 2025

Adding @vaishnavachath

Copy link
Contributor

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! Too bad the image is apparently not using a transparent background, missed that during initial review.

https://builds.zephyrproject.io/zephyr/pr/85156/docs/boards/index.html#name=launchpad
https://builds.zephyrproject.io/zephyr/pr/85156/docs/boards/ti/lp_em_cc2340r5/doc/index.html

image

@jpanisbl
Copy link
Contributor Author

jpanisbl commented Feb 4, 2025

Great, thanks! Too bad the image is apparently not using a transparent background, missed that during initial review.

I will try to change that while updating the Supported Features chapter of the documentation, when the other drivers will get upstream too. :)

@kartben kartben merged commit 70b6706 into zephyrproject-rtos:main Feb 6, 2025
24 checks passed
@jpanisbl jpanisbl deleted the baylibre/upstream-cc23x0-doc-fix branch October 17, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants