[backport v3.7-branch] bluetooth: host: hci_core: add missing NULL check
#85299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add check that the command buffer claimed in `bt_le_create_conn_cancel` is not `NULL`. Fixes a fault caused by providing the `NULL` buffer to `bt_hci_cmd_state_set_init`. Signed-off-by: Jordan Yates <[email protected]>
The extended advertising start procedure can consume both command buffers in a single API call, resulting in `bt_le_create_conn_cancel` being unable to claim a buffer to terminate the connection request. Increase the command count if both extended advertising and Bluetooth central are enabled in an application. Signed-off-by: Jordan Yates <[email protected]>
zephyrbot
added
area: Bluetooth
area: Bluetooth Host
zephyrbot
requested review from
Thalley,
Vudentz,
alwa-nordic,
asbjornsabo,
hermabe,
jhedberg,
jori-nordic,
sjanc and
theob-pro
cvinayak
approved these changes
Feb 6, 2025
|
|
||
| config BT_BUF_CMD_TX_COUNT | ||
| int "Number of HCI command buffers" | ||
| default 3 if BT_EXT_ADV && BT_CENTRAL |
There was a problem hiding this comment.
Just leaving a comment here that le_ext_adv_param_set uses 2 HCI Command Buffers in a nested format, starving the connection create cancel when invoked from system work queue to fail silently (This can happen if a pre-emptive thread is starting advertising).
The nested use of HCI Command Buffers will be fixed in b21c386
fabiobaltieri
approved these changes
Feb 11, 2025
Thalley
approved these changes
Feb 13, 2025
jhedberg
approved these changes
Feb 13, 2025
fabiobaltieri
approved these changes
Feb 13, 2025
fabiobaltieri
added
the
Trivial
jhedberg
changed the title
NULL checkNULL check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add check that the command buffer claimed in
bt_le_create_conn_cancelis notNULL. Fixes a fault caused by providing theNULLbuffer tobt_hci_cmd_state_set_init.Primary fix from #85260.
Increasing the command buffer count as discussed in Bluetooth WG 2025/02/06
Once the changes are validated here, a duplicate PR to the
v4.0branch will be created.Fixes #85301