Skip to content

Conversation

@DBS06
Copy link
Contributor

@DBS06 DBS06 commented Feb 6, 2025

This PR adds board support for the Adafruit ESP32-S2 Feather development boards with different flavors:

  • adafruit_feather/esp32s2/revb
  • adafruit_feather/esp32s2/revc
  • adafruit_feather/esp32s2/revc/max17048
  • adafruit_feather/esp32s2/tft/reverse
  • adafruit_feather/esp32s2/tft
  • adafruit_feather/esp32s2/tft/max17048

This is basically a copy and extension of #75844 and other boards i.e. pinout, feather connector, fuel gauge and on-board NeoPixel. There is an issue #68512 requesting support for this board.

@zephyrbot zephyrbot added area: Samples Samples area: Sensors Sensors area: Display area: LED Label to identify LED subsystem labels Feb 6, 2025
@DBS06 DBS06 changed the title Esp32s2 tft feather board: Adafruit ESP32-S2 Feather Feb 6, 2025
@DBS06 DBS06 force-pushed the esp32s2_tft_feather branch from e980d48 to 9e7b214 Compare February 6, 2025 19:33
Copy link
Contributor

@nordicjm nordicjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commits need squashing


&gpio0 {
status = "okay";
neopixel-power-enable {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newline

Comment on lines 137 to 142

/* SPI */
reg = <0>; /* ignored, but necessary for SPI bindings */
spi-max-frequency = <6400000>;

/* WS2812 */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/* SPI */
reg = <0>; /* ignored, but necessary for SPI bindings */
spi-max-frequency = <6400000>;
/* WS2812 */
reg = <0>;
spi-max-frequency = <6400000>;

<LED_COLOR_ID_BLUE>;
};
};

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@@ -0,0 +1,8 @@
# SPDX-License-Identifier: Apache-2.0

CONFIG_MAIN_STACK_SIZE=2048
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently have a PR getting rid of this

leds {
compatible = "gpio-leds";
status = "okay";
led1: led_1 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newline

@DBS06
Copy link
Contributor Author

DBS06 commented Feb 7, 2025

commits need squashing

Thanks for your Review, I wall do that asap

add support for esp32s2_feather boards

Signed-off-by: Philipp Steiner <[email protected]>
@DBS06 DBS06 force-pushed the esp32s2_tft_feather branch from fce563d to c4b6abe Compare February 7, 2025 13:09
@zephyrbot zephyrbot added the size: XS A PR changing only a single line of code label Feb 7, 2025
@DBS06
Copy link
Contributor Author

DBS06 commented Feb 7, 2025

Ok, somehow I messed up my branch, I will look into it to fix it the next days

@DBS06
Copy link
Contributor Author

DBS06 commented Feb 7, 2025

I have to close and reopen this PR because I really did some mess with my branch

@DBS06 DBS06 closed this Feb 7, 2025
@DBS06 DBS06 deleted the esp32s2_tft_feather branch March 28, 2025 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Display area: LED Label to identify LED subsystem area: Samples Samples area: Sensors Sensors size: XS A PR changing only a single line of code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants