Skip to content

Conversation

@quytranpzz
Copy link
Contributor

This PR is to:

@soburi
Copy link
Member

soburi commented Feb 12, 2025

Need to fix CI issues.

Copy link
Member

@soburi soburi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix CI issues.

@quytranpzz
Copy link
Contributor Author

Need to fix CI issues.

Sure.
Hi @kartben : sorry for bothering you. We plan to update the documentation for RA boards using zephyr:board instead in the rst files. But we encountered CI build errors (e.g. /home/runner/work/zephyr/zephyr/doc/_build/src/releases/release-notes-4.0.rst:306: WARNING: undefined label: 'ek_ra2a1' [ref.ref]). As my understanding, the release notes currently use :ref:Renesas RA2A1 Evaluation Kit <ek_ra2a1> (ek_ra2a1), Should I update it or do something else? Please take a look. Thank you very much

@zephyrbot zephyrbot added the Release Notes To be mentioned in the release notes label Feb 18, 2025
@kartben
Copy link
Contributor

kartben commented Feb 18, 2025

Need to fix CI issues.

Sure. Hi @kartben : sorry for bothering you. We plan to update the documentation for RA boards using zephyr:board instead in the rst files. But we encountered CI build errors (e.g. /home/runner/work/zephyr/zephyr/doc/_build/src/releases/release-notes-4.0.rst:306: WARNING: undefined label: 'ek_ra2a1' [ref.ref]). As my understanding, the release notes currently use :ref:Renesas RA2A1 Evaluation Kit <ek_ra2a1> (ek_ra2a1), Should I update it or do something else? Please take a look. Thank you very much

sorry I missed the notification. Yes, updating the old references like you've done is fine (although it's probably not ideal to have to touch old release notes)

Copy link
Contributor

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@quytranpzz
Very nice to see! Is there a reason you left out some boards, e.g ek_ra4m1, fpb_ra4e1, voice_ra4e1?

@quytranpzz
Copy link
Contributor Author

@quytranpzz Very nice to see! Is there a reason you left out some boards, e.g ek_ra4m1, fpb_ra4e1, voice_ra4e1?

Hi @kartben : The new format has already been used in the documentation for those boards. This PR updates the boards introduced in versions 3.7 and 4.0.

@kartben
Copy link
Contributor

kartben commented Feb 18, 2025

@quytranpzz Very nice to see! Is there a reason you left out some boards, e.g ek_ra4m1, fpb_ra4e1, voice_ra4e1?

Hi @kartben : The new format has already been used in the documentation for those boards. This PR updates the boards introduced in versions 3.7 and 4.0.

duh - of course! Sorry :)

Copy link
Contributor

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work - just a minor request from my side

Comment on lines 2 to 4
RA2A1 Evaluation Kit
####################
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is redundant (see screenshot) and taken care of by the zephyr:board directive. Please cleanup in other boards in the PR and also existing boards like ra4m1 etc.

Suggested change
RA2A1 Evaluation Kit
####################
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed that part for all the current boards. Thanks for pointing that out.

kartben
kartben previously approved these changes Feb 18, 2025
@quytranpzz quytranpzz requested a review from soburi February 18, 2025 08:57
Comment on lines -1 to -4
.. _mcb_ra8t1:

RA8T1 Evaluation Kit
####################
Copy link
Member

@duynguyenxa duynguyenxa Feb 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@quytranpzz , There are still 1 place in this doc that mention this kit names wrong. Please help to correct it as well. Thank you

.. figure:: mck_ra8t1_product_contents.jpg
	:align: center
	:alt: RA8T1 Evaluation Kit
	MCK-RA8T1 product contents (Credit: Renesas Electronics Corporation)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I have corrected the MCK-RA8T1 board name.

- Update boards documetation with new format
- Correct typo for documentation of RA boards

Signed-off-by: Quy Tran <[email protected]>
- Move config BUILD_OUTPUT_HEX and CLOK_CONTROL from board deconfig
into SoC deconfig
- Add clock-frequency in dts to get config
SYS_CLOCK_HW_CYCLES_PER_SEC from dts

Signed-off-by: Quy Tran <[email protected]>
This updates the release notes to use zephyr:board for
Renesas RA boards

Signed-off-by: Quy Tran <[email protected]>
@fabiobaltieri fabiobaltieri added this to the v4.1.0 milestone Feb 18, 2025
@fabiobaltieri
Copy link
Member

fabiobaltieri commented Feb 18, 2025

There's a bit more than just documentation though, I think it's fine to merge it since we are just in RC1 and there should be no actual configuration just but @kartben please take a look as well.

@kartben
Copy link
Contributor

kartben commented Feb 18, 2025

There's a bit more than just documentation though, I think it's fine to merge it since we are just in RC1 and there should be no actual configuration just but @kartben please take a look as well.

ya refreshing my +1 :) The other changes are fine with me

@kartben kartben merged commit e1c8805 into zephyrproject-rtos:main Feb 18, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

platform: Renesas RA Renesas Electronics Corporation, RA Release Notes To be mentioned in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants