mgmt: mcumgr: smp: Fix custom payload size #85604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue when using custom payloads where the size was still using the zcbor buffer instead of the size of the network buffer Signed-off-by: Jamie McCrae <[email protected]>
de-nordic
approved these changes
Feb 11, 2025
pdgendt
approved these changes
Feb 12, 2025
Comment on lines
+313
to
+319
| #if defined(CONFIG_MCUMGR_MGMT_CUSTOM_PAYLOAD) | ||
| if (!mgmt_find_group(req_hdr->nh_group)->custom_payload) { | ||
| #endif | ||
| nbw->nb->len = zsp->payload_mut - nbw->nb->data; | ||
| #if defined(CONFIG_MCUMGR_MGMT_CUSTOM_PAYLOAD) | ||
| } | ||
| #endif |
Contributor
There was a problem hiding this comment.
Not sure if this increases readability
if (COND_CODE_1(CONFIG_MCUMGR_MGMT_CUSTOM_PAYLOAD,
(!mgmt_find_group(req_hdr->nh_group)->custom_payload), (true))) {
nbw->nb->len = zsp->payload_mut - nbw->nb->data;
}
|
Can you make these changes in version 3.7.1? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue when using custom payloads where the size was still using the zcbor buffer instead of the size of the network buffer
Fixes #85521