Skip to content

Bluetooth: Controller: Fix regression in scan aux release #85705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 17, 2025
Merged

Bluetooth: Controller: Fix regression in scan aux release #85705

merged 2 commits into from
Feb 17, 2025

Conversation

@cvinayak
Copy link
Contributor

@cvinayak cvinayak commented Feb 13, 2025 •
edited
Loading

Fix regression in scan aux release now that aux context is retrieved from the node rx when supporting multiple chain reception.

The regression was detected on target when testing in comparison of design as part of #85717.

Relates to commit a806592 ("Bluetooth: Controller: Fix to release aux context stored in node rx").

@cvinayak cvinayak force-pushed the github_scan_aux_release_fix branch 3 times, most recently from 85d5716 to dc72399 Compare February 13, 2025 07:51
@cvinayak cvinayak changed the title Bluetooth: Controller: Fix redundant code in scan aux release Bluetooth: Controller: Fix regression in scan aux release Feb 13, 2025
@cvinayak cvinayak marked this pull request as ready for review February 13, 2025 07:52
@cvinayak cvinayak added bug The issue is a bug, or the PR is fixing a bug Regression Something, which was working, does not anymore backport v4.0-branch Backport to the v4.0-branch labels Feb 13, 2025
@cvinayak cvinayak added this to the v4.1.0 milestone Feb 13, 2025
@cvinayak cvinayak requested a review from Thalley February 13, 2025 11:36
Thalley
Thalley requested changes Feb 13, 2025
View reviewed changes
@cvinayak
Bluetooth: Controller: Fix regression in scan aux release
6508c87 
Fix regression in scan aux release now that aux context is
retrieved from the node rx when supporting multiple chain
reception.

Relates to commit a806592 ("Bluetooth: Controller: Fix
to release aux context stored in node rx").

Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
@cvinayak
Bluetooth: Controller: Fix redundant reset of sync aux association
d282b1f 
Remove redundant reset of LLL sync aux context association.

Related to commit 3263729 ("Bluetooth: Controller: Fix
assertion terminating Periodic Sync").

Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
@cvinayak cvinayak force-pushed the github_scan_aux_release_fix branch from dc72399 to d282b1f Compare February 13, 2025 17:17
@cvinayak cvinayak requested a review from Thalley February 14, 2025 12:12
@cvinayak
Copy link
Contributor Author

cvinayak commented Feb 17, 2025 •
edited
Loading

Some 11 million advertising reports have been generated over the weekend using a custom observer sample. Hopefully must have covered any possible edge conditions and no regression in extended scanning loosing aux context or rx buffers.

[2025-02-17 14:37:17.988] 11000691. [DEVICE]: 22:0B:88:C0:3C:57 (random), AD evt type 3, Tx Pwr: 127, RSSI -79 Data status: 0, AD data len: 31 Name:  C:0 S:0 D:0 SR:0 E:0 Pri PHY: LE 1M, Sec PHY: No packets, Interval: 0x0000 (0 ms), SID: 255
[2025-02-17 14:37:18.006] 11000692. [DEVICE]: 29:1D:0A:3A:2E:9A (random), AD evt type 5, Tx Pwr: 127, RSSI -37 Data status: 0, AD data len: 31 Name: Broadcaster Multiple C:0 S:0 D:0 SR:0 E:1 Pri PHY: LE 1M, Sec PHY: LE 2M, Interval: 0x0000 (0 ms), SID: 3
[2025-02-17 14:37:18.027] 11000693. [DEVICE]: 31:DC:3A:1C:76:40 (random), AD evt type 5, Tx Pwr: 127, RSSI -37 Data status: 0, AD data len: 31 Name: Broadcaster Multiple C:0 S:0 D:0 SR:0 E:1 Pri PHY: LE 1M, Sec PHY: LE 2M, Interval: 0x0000 (0 ms), SID: 15
[2025-02-17 14:37:18.048] 11000694. [DEVICE]: 04:1D:9C:89:54:62 (random), AD evt type 5, Tx Pwr: 127, RSSI -37 Data status: 0, AD data len: 31 Name: Broadcaster Multiple C:0 S:0 D:0 SR:0 E:1 Pri PHY: LE 1M, Sec PHY: LE 2M, Interval: 0x0000 (0 ms), SID: 2
[2025-02-17 14:37:18.068] 11000695. [DEVICE]: 1C:4D:AB:1A:CE:1C (random), AD evt type 5, Tx Pwr: 127, RSSI -63 Data status: 0, AD data len: 27 Name: Test Periodic Advertising C:0 S:0 D:0 SR:0 E:1 Pri PHY: LE 1M, Sec PHY: LE 2M, Interval: 0x03c0 (1200 ms), SID: 0
[2025-02-17 14:37:18.090] 11000696. [DEVICE]: 22:0B:88:C0:3C:57 (random), AD evt type 3, Tx Pwr: 127, RSSI -78 Data status: 0, AD data len: 31 Name:  C:0 S:0 D:0 SR:0 E:0 Pri PHY: LE 1M, Sec PHY: No packets, Interval: 0x0000 (0 ms), SID: 255
[2025-02-17 14:37:18.109] 11000697. [DEVICE]: 28:64:BD:88:8E:8A (random), AD evt type 3, Tx Pwr: 127, RSSI -74 Data status: 0, AD data len: 31 Name:  C:0 S:0 D:0 SR:0 E:0 Pri PHY: LE 1M, Sec PHY: No packets, Interval: 0x0000 (0 ms), SID: 255
[2025-02-17 14:37:18.129] 11000698. [DEVICE]: 21:8E:56:A3:24:9D (random), AD evt type 5, Tx Pwr: 127, RSSI -30 Data status: 0, AD data len: 31 Name: Broadcaster Multiple C:0 S:0 D:0 SR:0 E:1 Pri PHY: LE Coded, Sec PHY: LE Coded, Interval: 0x0000 (0 ms), SID: 2
[2025-02-17 14:37:18.150] 11000699. [DEVICE]: 32:EF:6A:A3:CF:D9 (random), AD evt type 5, Tx Pwr: 127, RSSI -38 Data status: 0, AD data len: 31 Name: Broadcaster Multiple C:0 S:0 D:0 SR:0 E:1 Pri PHY: LE 1M, Sec PHY: LE 2M, Interval: 0x0000 (0 ms), SID: 2
[2025-02-17 14:37:18.175] 11000700. [DEVICE]: CA:10:EB:D9:D3:A0 (random), AD evt type 5, Tx Pwr: 127, RSSI -65 Data status: 0, AD data len: 36 Name: Zephyr Heartrate Sensor C:1 S:0 D:0 SR:0 E:1 Pri PHY: LE 1M, Sec PHY: LE 1M, Interval: 0x0000 (0 ms), SID: 0
[2025-02-17 14:37:18.193] 11000701. [DEVICE]: 70:D4:5E:BD:51:F0 (public), AD evt type 5, Tx Pwr: 127, RSSI -45 Data status: 0, AD data len: 46 Name: u-blox AoA 1M C:0 S:0 D:0 SR:0 E:1 Pri PHY: LE 1M, Sec PHY: LE 1M, Interval: 0x0028 (50 ms), SID: 0
[2025-02-17 14:37:18.213] 11000702. [DEVICE]: 61:F0:97:FE:C9:66 (random), AD evt type 0, Tx Pwr: 127, RSSI -83 Data status: 0, AD data len: 19 Name:  C:1 S:1 D:0 SR:0 E:0 Pri PHY: LE 1M, Sec PHY: No packets, Interval: 0x0000 (0 ms), SID: 255
[2025-02-17 14:37:18.232] 11000703. [DEVICE]: 28:64:BD:88:8E:8A (random), AD evt type 3, Tx Pwr: 127, RSSI -85 Data status: 0, AD data len: 31 Name:  C:0 S:0 D:0 SR:0 E:0 Pri PHY: LE 1M, Sec PHY: No packets, Interval: 0x0000 (0 ms), SID: 255
[2025-02-17 14:37:18.251] 11000704. [DEVICE]: 24:FF:2F:0C:F9:D5 (random), AD evt type 5, Tx Pwr: 127, RSSI -38 Data status: 0, AD data len: 31 Name: Broadcaster Multiple C:0 S:0 D:0 SR:0 E:1 Pri PHY: LE 1M, Sec PHY: LE 2M, Interval: 0x0000 (0 ms), SID: 1
[2025-02-17 14:37:18.273] 11000705. [DEVICE]: 30:64:ED:35:52:D6 (random), AD evt type 5, Tx Pwr: 127, RSSI -40 Data status: 0, AD data len: 31 Name: Broadcaster Multiple C:0 S:0 D:0 SR:0 E:1 Pri PHY: LE 1M, Sec PHY: LE 2M, Interval: 0x0000 (0 ms), SID: 4
[2025-02-17 14:37:18.293] 11000706. [DEVICE]: 17:2D:4C:B3:86:EC (random), AD evt type 5, Tx Pwr: 127, RSSI -39 Data status: 0, AD data len: 31 Name: Broadcaster Multiple C:0 S:0 D:0 SR:0 E:1 Pri PHY: LE 1M, Sec PHY: LE 2M, Interval: 0x0000 (0 ms), SID: 6
[2025-02-17 14:37:18.314] 11000707. [DEVICE]: 1E:88:25:04:59:C5 (random), AD evt type 5, Tx Pwr: 127, RSSI -40 Data status: 0, AD data len: 31 Name: Broadcaster Multiple C:0 S:0 D:0 SR:0 E:1 Pri PHY: LE 1M, Sec PHY: LE 2M, Interval: 0x0000 (0 ms), SID: 14
[2025-02-17 14:37:18.335] 11000708. [DEVICE]: 47:63:4A:75:29:95 (random), AD evt type 0, Tx Pwr: 127, RSSI -90 Data status: 0, AD data len: 29 Name: Jabra Evolve2 65 C:1 S:1 D:0 SR:0 E:0 Pri PHY: LE 1M, Sec PHY: No packets, Interval: 0x0000 (0 ms), SID: 255
[2025-02-17 14:37:18.356] 11000709. [DEVICE]: 04:1D:9C:89:54:62 (random), AD evt type 5, Tx Pwr: 127, RSSI -38 Data status: 0, AD data len: 31 Name: Broadcaster Multiple C:0 S:0 D:0 SR:0 E:1 Pri PHY: LE 1M, Sec PHY: LE 2M, Interval: 0x0000 (0 ms), SID: 2

@fabiobaltieri fabiobaltieri merged commit dcdd330 into zephyrproject-rtos:main Feb 17, 2025
25 checks passed
@zephyrbot zephyrbot mentioned this pull request Feb 17, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Thalley Thalley Thalley approved these changes

@carlescufi carlescufi carlescufi approved these changes

@erbr-ot erbr-ot Awaiting requested review from erbr-ot

@mtpr-ot mtpr-ot Awaiting requested review from mtpr-ot

@thoh-ot thoh-ot Awaiting requested review from thoh-ot

@wopu-ot wopu-ot Awaiting requested review from wopu-ot

Assignees

@cvinayak cvinayak

Labels

area: Bluetooth Controller area: Bluetooth backport v4.0-branch Backport to the v4.0-branch bug The issue is a bug, or the PR is fixing a bug Regression Something, which was working, does not anymore

Projects

None yet

Milestone

v4.1.0

Development

Successfully merging this pull request may close these issues.

5 participants

@cvinayak @Thalley @carlescufi @fabiobaltieri @zephyrbot