Skip to content

[Backport v4.1-branch] drivers: i3c: fix multiple issues in common code, shell, and CCC #86788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: v4.1-branch
Choose a base branch
from
+6 −3
Open

[Backport v4.1-branch] drivers: i3c: fix multiple issues in common code, shell, and CCC #86788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9511aac
drivers: i3c: common: fix the setaasa flow
Chenhongren Feb 27, 2025
74735e1
drivers: i3c: shell: fix the judgement/argc count for getstatus/ibi tir
Chenhongren Mar 3, 2025
43ebadd
drivers: i3c: ccc: add missing data length for entas
Chenhongren Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions drivers/i3c/i3c_ccc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,7 @@ int i3c_ccc_do_entas(const struct i3c_device_desc *target, uint8_t as)

ccc_tgt_payload.addr = target->dynamic_addr;
ccc_tgt_payload.rnw = 0;
ccc_tgt_payload.data_len = 0;

ccc_payload.ccc.id = I3C_CCC_ENTAS(as, false);
ccc_payload.targets.payloads = &ccc_tgt_payload;
Expand Down
2 changes: 2 additions & 0 deletions drivers/i3c/i3c_common.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1088,6 +1088,8 @@ int i3c_bus_init(const struct device *dev, const struct i3c_dev_list *dev_list)
if (need_aasa) {
ret = i3c_ccc_do_setaasa_all(dev);
if (ret != 0) {
LOG_ERR("failed to perform setaasa");
} else {
for (i = 0; i < dev_list->num_i3c; i++) {
struct i3c_device_desc *desc = &dev_list->i3c[i];
/*
Expand Down
6 changes: 3 additions & 3 deletions drivers/i3c/i3c_shell.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1430,7 +1430,7 @@ static int cmd_i3c_ccc_getstatus(const struct shell *sh, size_t argc, char **arg
if (argc > 3) {
fmt = GETSTATUS_FORMAT_2;
defbyte = strtol(argv[3], NULL, 16);
if (defbyte != GETSTATUS_FORMAT_2_TGTSTAT || defbyte != GETSTATUS_FORMAT_2_PRECR) {
if (defbyte != GETSTATUS_FORMAT_2_TGTSTAT && defbyte != GETSTATUS_FORMAT_2_PRECR) {
shell_error(sh, "Invalid defining byte.");
return -EINVAL;
}
Expand Down Expand Up @@ -2075,9 +2075,9 @@ static int cmd_i3c_ibi_tir(const struct shell *sh, size_t argc, char **argv)
return -ENODEV;
}

data_length = argc - 3;
data_length = argc - 2;
for (i = 0; i < data_length; i++) {
buf[i] = (uint8_t)strtol(argv[3 + i], NULL, 16);
buf[i] = (uint8_t)strtol(argv[2 + i], NULL, 16);
}

request.ibi_type = I3C_IBI_TARGET_INTR;
Expand Down
Loading