boards: adafruit: add initial support for esp32 feather v2 #87177
Conversation
zephyrbot
requested review from
Mani-Sadhasivam,
kartben,
nashif and
simonguinot
|
Hello @lvoytek, and thank you very much for your first pull request to the Zephyr project! |
| name: adafruit_feather_esp32_v2 | ||
| full_name: Adafruit ESP32 Feather V2 |
There was a problem hiding this comment.
this should be adafruit_feather_esp32 and use a board revision https://docs.zephyrproject.org/latest/hardware/porting/board_porting.html#multiple-board-revisions
There was a problem hiding this comment.
Updated naming and added a single default "2" revision. I know it's deprecated but if there's interest I could also port V1 since I still own several of them :)
boards/adafruit/feather_esp32_v2/doc/img/adafruit_feather_esp32_v2.jpg
Outdated
Show resolved
Hide resolved
boards/adafruit/feather_esp32/adafruit_feather_esp32_appcpu.yaml
Outdated
Show resolved
Hide resolved
|
Thanks for the review @sylvioalves! Updated based on your comments |
| @@ -0,0 +1,11 @@ | |||
| board: | |||
| name: adafruit_feather_esp32 | |||
| full_name: Adafruit ESP32 Feather | |||
There was a problem hiding this comment.
Nit: all the other supported Feather boards are named "Adafruit Feather XXX"
| full_name: Adafruit ESP32 Feather | |
| full_name: Adafruit Feather ESP32 |
There was a problem hiding this comment.
That's fair. I originally named it based on the adafruit.com listing but now I see all ESP32 feathers there now use the "Adafruit ESP32... Feather" convention. It's definitely better to have naming consistency here, so I've updated the name in the yml and dts files :)
The Adafruit ESP32 Feather V2 is a board that uses the Feather standard layout. It uses an ESP32-PICO v3 02 module, and includes a USB-C connector, LiPo battery charger, NeoPixel RGB LED, and STEMMA QT connector. Signed-off-by: Lena Voytek <[email protected]>
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
|
|
Hi @lvoytek! To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge. Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁 |
8 participants
The Adafruit ESP32 Feather V2 is a board that uses the Feather standard layout. It uses an ESP32-PICO v3 02 module, and includes a USB-C connector, LiPo battery charger, NeoPixel RGB LED, and STEMMA QT connector.
Not to be confused with the adafruit esp32s3 feather, which I noticed was just added a few days ago :)