-
Notifications
You must be signed in to change notification settings - Fork 8k
edtlib: Add static type hint stub files for mypy #88016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
c2902af
to
0e5825d
Compare
0e5825d
to
82bd2de
Compare
Let me restart the ci process. Edit: It seems to work. |
3e33e91
to
78ea3fb
Compare
Hmn, with the # in .ruff-excludes.toml
"./scripts/dts/python-devicetree/src/devicetree/dtlib.py" = [
"UP007", # https://docs.astral.sh/ruff/rules/non-pep604-annotation
]
"./scripts/dts/python-devicetree/src/devicetree/edtlib.py" = [
"UP007", # https://docs.astral.sh/ruff/rules/non-pep604-annotation
] So that the interface and actual implementation have the same declarations. |
8c8b621
to
1ca54aa
Compare
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
@rruuaanng Please rebase on |
@henrikbrixandersen |
1ca54aa
to
f623b90
Compare
@rruuaanng can you please check CI and update again so we can get this in? |
0de5321
to
c362813
Compare
Add stub files (.pyi) for "edtlib.py" and "dtlib.py" to improve mypy static analysis and code completion. Signed-off-by: James Roy <[email protected]>
de707ab
to
57fe48a
Compare
Add stub files (.pyi) for "edtlib.py" and "dtlib.py" to improve mypy static analysis and code completion. Signed-off-by: James Roy <[email protected]>
57fe48a
to
a75694a
Compare
@rruuaanng I think this never got addressed? How/when do you expect people to update these files? There's already good do's/don'ts at the top of dtlib/edtlib files so it would probably be good to add a not there w.r.t what people must do what they add new APIs etc |
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
Maybe I should mention that in the README. I'll add it. |
Add stub files (.pyi) for "edtlib.py" and "dtlib.py" to improve mypy static analysis and code completion.