[Backport v4.0-branch] sensor: adxl345: Decoder bug-fixes #88136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used by the sensor-shell in order to retrieve values, otherwise it crashes. Signed-off-by: Luis Ubieda <[email protected]>
The following fixes have been applied to this decoder: - The Q-scale factor was fixed, both for full-scale and non full-scale modes. - The data-type decoded is struct sensor_three_axis_data, as it should for read/decode API. Signed-off-by: Luis Ubieda <[email protected]>
Otherwise with its default configuration (25-Hz, 32-level FIFO), getting individual samples could be up to 1-second old. Signed-off-by: Luis Ubieda <[email protected]>
Have the application enable this feature explicitcly, so that simple applications do not need to disable this to get the expected behavior. Signed-off-by: Luis Ubieda <[email protected]>
Member
Author
|
Not sure why CI PR Assigner did not work |
MaureenHelm
approved these changes
Apr 4, 2025
teburd
approved these changes
Apr 4, 2025
yperess
approved these changes
Apr 4, 2025
dkalowsk
approved these changes
Apr 12, 2025
Contributor
|
@ubieda looks like some CI fun needing resolution for this one. |
Member
Author
|
Brought it up on Discord's CI channel. Waiting for a resolution: https://discord.com/channels/720317445772017664/1014241011989487716/1361340451499544626 |
zephyrbot
requested review from
avisconti,
galak,
jeppenodgaard,
microbuilder,
ozersa,
tristan-google and
ttmut
|
dkalowsk
merged commit d4374ed
into
zephyrproject-rtos:v4.0-branch
53 of 56 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manually backporting #83476 into
v4.0-branch.Fixes #84264