Skip to content

Conversation

@FKainka
Copy link
Contributor

@FKainka FKainka commented Apr 25, 2025

This PR is related to the following Zephyr PR:
#81431 Some compilers (e.g. arm-zephyr-eabi-gcc) don't understand the K_SPINLOCK() macro and therefore do warn about uninitialized variables in the modem related modules.

Signed-off-by: Fabian Kainka [email protected]

@github-actions
Copy link

Hello @FKainka, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

Copy link
Contributor

@bjarki-andreasen bjarki-andreasen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you instead replace the K_SPINLOCK macros with the "normal" lock+unlock calls? initializing the variables uses more ROM, so its not free to initialize them :)

@FKainka FKainka closed this May 20, 2025
@FKainka FKainka force-pushed the feature/fix-modem-modules-uninitialized-vars branch from a1fdeee to 042bf2c Compare May 20, 2025 06:32
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants