Add HL78XX Modem Driver Implementation Using Modem Chat Framework #89541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rerickson1
requested changes
May 7, 2025
rerickson1
reviewed
May 7, 2025
rerickson1
reviewed
May 7, 2025
zafersn
force-pushed
the
hl78xx_driver
branch
2 times, most recently
from
31e6d9f to
b1e6ffc
Compare
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces the initial HL78XX modem driver implementation based on the modem_chat framework while updating sample applications to integrate power management calls. Key changes include:
- Adding power management includes and calls in sample applications to power on the modem.
- Enhancing the modem socket poll routine with temporary POLLOUT handling.
- Introducing new HL78XX utility and header files to support modem functionality.
Reviewed Changes
Copilot reviewed 8 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| samples/net/lwm2m_client/src/lwm2m-client.c | Added power management headers and a power-on invocation for the HL78XX modem. |
| samples/net/cloud/aws_iot_mqtt/src/main.c | Added similar power management initialization for the modem in the AWS IoT MQTT sample. |
| drivers/modem/modem_socket.c | Updated POLLOUT event handling with temporary logging and fallback behavior. |
| drivers/modem/hl78xx/hl78xx_utility.c | Added HL78XX utility functions; note an inconsistent module name in the log registration. |
| drivers/modem/hl78xx/hl78xx.h | Introduced declarations and definitions supporting the HL78XX modem driver. |
Files not reviewed (6)
- drivers/modem/CMakeLists.txt: Language not supported
- drivers/modem/Kconfig: Language not supported
- drivers/modem/hl78xx/CMakeLists.txt: Language not supported
- samples/net/cloud/aws_iot_mqtt/boards/hl78xx_chat.conf: Language not supported
- samples/net/lwm2m_client/Kconfig: Language not supported
- samples/net/lwm2m_client/overlay-hl78xx_chat.conf: Language not supported
Comments suppressed due to low confidence (1)
drivers/modem/hl78xx/hl78xx_utility.c:18
- [nitpick] The module name 'hl7812_utility' appears inconsistent with the HL78XX naming convention used elsewhere. Consider renaming it to 'hl78xx_utility' for naming consistency.
LOG_MODULE_REGISTER(hl7812_utility, CONFIG_MODEM_LOG_LEVEL);
c4e404b to
df0f647
Compare
rerickson1
reviewed
Oct 8, 2025
rerickson1
reviewed
Oct 8, 2025
rerickson1
reviewed
Oct 8, 2025
zafersn
force-pushed
the
hl78xx_driver
branch
3 times, most recently
from
440ca12 to
ecbc759
Compare
|
This PR depends on this fix if using the UART ISR backend: #97132 |
rerickson1
reviewed
Oct 9, 2025
rerickson1
reviewed
Oct 9, 2025
Adding HL78XX Modem Driver Implementation Using Modem Chat Framework Signed-off-by: Zafer SEN <[email protected]>
Add HL78xx driver sample application Signed-off-by: Zafer SEN <[email protected]>
add support for HL78xx driver Signed-off-by: Zafer SEN <[email protected]>
add support for HL78xx driver Signed-off-by: Zafer SEN <[email protected]>
Add support for Pinnacle 100 modem (HL7800) platforms. Signed-off-by: Ryan Erickson <[email protected]>
Add support for using the HL78XX modem driver with Pinnacle 100 modem boards. Signed-off-by: Ryan Erickson <[email protected]>
Add support for using the HL78XX modem driver with Pinnacle 100 modem boards. Signed-off-by: Ryan Erickson <[email protected]>
rerickson1
force-pushed
the
hl78xx_driver
branch
from
ca58b70 to
98abcc1
Compare
|
rerickson1
approved these changes
Oct 9, 2025
There was a problem hiding this comment.
I have tested this driver against the Pinnacle 100 DVK (HL7800).
The following samples were tested:
- AWS IoT (MQTT, TCP, TLS)
- LwM2M client (CoAP, UDP, DTLS)
- HL78XX Hello
All samples run great. This PR is ready for others review.
@jukkar, ready for your re-review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the initial draft implementation of the HL78XX modem driver, built on the
modem_chatframework. The current version establishes the core structure and essential functionality required to support the HL78XX modem series.The primary objective at this stage is to review and align on the overall design and integration approach. Following this, development will continue with additional features such as:
Power saving mode support
User pipe connection handling
Other modem-specific enhancements
Verified compatibility and correct operation with the following sample applications:
aws_mqttdns_resolvebig_http_downloadlwm2mFeedback on both structure and test approach is welcome.