Skip to content

Conversation

Thalley
Copy link
Contributor

@Thalley Thalley commented May 8, 2025

Change the ACL buffer sizes to be a higher value than the default, as that caused some issues with the CIS established event.

Relates to #88300.

Change the ACL buffer sizes to be a higher value than the
default, as that caused some issues with the CIS established
event.

Signed-off-by: Emil Gydesen <[email protected]>
@Thalley
Copy link
Contributor Author

Thalley commented May 8, 2025

#AutoPTS run zephyr nrf53 CAP/INI/UST/BV-01-C

@codecoup-tester
Copy link

Scheduled PR #89680 (comment), board: nrf53, estimated start time: 19:24:29, test case count: 1, estimated duration: 0:10:50

Test cases to be runCAP/INI/UST/BV-01-C

@codecoup-tester
Copy link

AutoPTS Bot results:
No failed test found.

Successful tests (1)CAP CAP/INI/UST/BV-01-C PASS

@Thalley
Copy link
Contributor Author

Thalley commented May 8, 2025

CONFIG_BT_BUF_ACL_TX_SIZE didn't need to be set for this to pass, but decided to keep the RX and TX values similar for good measure

@Thalley Thalley requested a review from cvinayak May 8, 2025 17:42
Copy link

sonarqubecloud bot commented May 8, 2025

Comment on lines +70 to +74

# ACL data sizes
CONFIG_BT_BUF_ACL_TX_SIZE=251
CONFIG_BT_BUF_ACL_RX_SIZE=255
CONFIG_BT_CTLR_DATA_LENGTH_MAX=251
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be use of 27 bytes as max ACL data size exposes a bug in the Zephyr Controller? This should be easily reproducible in bsim CI tests with the hci_ipc and nrf52_bsim audio tests with 27 byte ACL configured, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like a bug in the controller, yes, but not sure how to properly determine that yet.

I did try to run the test from #87207 which would also connect the CIS using the same BT Tester build, but at least in BSIM it doesn't seem to fail. Could be due to timing and availability of buffers?

@Thalley Thalley requested a review from cvinayak May 9, 2025 09:55
@Thalley Thalley added the Hotfix Fix for issues blocking development, i.e. CI issues, tests failing in CI, etc. label May 9, 2025
@kartben kartben merged commit eeb1d92 into zephyrproject-rtos:main May 9, 2025
29 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in Bluetooth LE Audio May 9, 2025
@Thalley Thalley deleted the bttester_acl_sizes_fix branch May 9, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Bluetooth Audio area: Bluetooth Qualification Bluetooth Qualification -related issues and pull requests area: Bluetooth Hotfix Fix for issues blocking development, i.e. CI issues, tests failing in CI, etc.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants