Skip to content

Conversation

ragurram26
Copy link
Contributor

@ragurram26 ragurram26 commented May 9, 2025

To support the SiWx917 Network Stack Application
protocol offloading, we need to add the Silicon Labs APIs,
so adding the corresponding source files and include files

Copy link

github-actions bot commented May 9, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_silabs zephyrproject-rtos/hal_silabs@a0095a7 (main) zephyrproject-rtos/hal_silabs#100 zephyrproject-rtos/hal_silabs#100/files

DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@github-actions github-actions bot added manifest manifest-hal_silabs DNM (manifest) This PR should not be merged (controlled by action-manifest) labels May 9, 2025
@ragurram26 ragurram26 changed the title Adding SL Embedded TA APIs Adding Silabs Embedded TA APIs May 9, 2025
@jhedberg
Copy link
Member

jhedberg commented May 9, 2025

@ragurram26 please provide a more detailed PR & commit message description, explaining the background to this, why this is needed, etc. Also most people in a Zephyr context won't know what "TA" is, so you need to explain that as well. If you're adding new APIs (like the title implies) I'd also expect to see some sample code to demonstrate their usage and provide code coverage for CI.

@jhedberg
Copy link
Member

jhedberg commented May 9, 2025

One other thing: when you have to enumerate multiple independent changes in a single commit message (like you're doing now), it's a clear indication that you should split this up into multiple commits.

net_if_dormant_off(sidev->iface);
}

#ifndef CONFIG_WIFI_SILABS_SIWX91X_NET_STACK_OFFLOAD
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this use if (!IS_ENABLED(CONFIG_WIFI_SILABS_SIWX91X_NET_STACK_OFFLOAD)) {?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@ragurram26 ragurram26 changed the title Adding Silabs Embedded TA APIs Adding Silabs Embedded SiWx917 APIs May 9, 2025
@ragurram26 ragurram26 force-pushed the Embedded_TA_stack branch from 8d5e691 to 8b9c083 Compare May 9, 2025 10:01
@ragurram26
Copy link
Contributor Author

ragurram26 commented May 9, 2025

@jhedberg I have updated the description .

I'd also expect to see some sample code to demonstrate their usage and provide code coverage for CI.
Should we include the application in this pull request, or is there an alternative method to ensure code coverage for continuous integration (CI)?

@ragurram26 ragurram26 force-pushed the Embedded_TA_stack branch from 8b9c083 to 6966645 Compare May 9, 2025 10:10
@rettichschnidi rettichschnidi removed their request for review May 12, 2025 07:40
To support the SiWx917 MQTT Network Stack Application
protocol offloading, we need to integrate the Silicon
Labs APIs, so adding the corresponding source files
and include files in the kconfig and CMakelist

Signed-off-by: Rahul Gurram <[email protected]>
@ragurram26 ragurram26 force-pushed the Embedded_TA_stack branch from ee877f9 to 9d1e3a7 Compare June 5, 2025 05:21
To support the SiWx917 ICMP Network Stack Application
protocol offloading, we need to integrate the Silicon
Labs APIs, so adding the corresponding source files
and include files in the kconfig and CMakelist

Signed-off-by: Rahul Gurram <[email protected]>
@ragurram26 ragurram26 force-pushed the Embedded_TA_stack branch from 9d1e3a7 to 2605581 Compare June 5, 2025 05:23
To support the SiWx917 Websockets Network Stack Application
protocol offloading, we need to integrate the Silicon Labs
APIs, so adding the corresponding source files and include
files in the kconfig and CMakelist

Signed-off-by: Rahul Gurram <[email protected]>
@ragurram26 ragurram26 force-pushed the Embedded_TA_stack branch from 2605581 to fa99358 Compare June 5, 2025 05:24
To support the SiWx917 MDNS Network Stack Application
protocol offloading, we need to integrate the Silicon Labs
APIs, so adding the corresponding source files and include
files in the kconfig and CMakelist

Signed-off-by: Rahul Gurram <[email protected]>
@ragurram26 ragurram26 force-pushed the Embedded_TA_stack branch from fa99358 to 594923e Compare June 5, 2025 05:25
To support the SiWx917 DNS Network Stack Application
protocol offloading, we need to integrate the Silicon Labs
APIs, so adding the corresponding source files and include
files in the kconfig and CMakelist

Signed-off-by: Rahul Gurram <[email protected]>
To support the SiWx917 TLS Sockets , Need to
enable the TLS bitmap in the intilization

Signed-off-by: Rahul Gurram <[email protected]>
To support the SiWx917 Single TLS Sockets,
Need to enable the Single TLS bitmap in
the intilization

Signed-off-by: Rahul Gurram <[email protected]>
@ragurram26 ragurram26 force-pushed the Embedded_TA_stack branch from 594923e to 59bb2ac Compare June 5, 2025 05:26
To support the SiWx917 Three SSL Sockets,
Need to enable the Three SSL bitmap in
the intilization

Signed-off-by: Rahul Gurram <[email protected]>
To support the SiWx917 SSL high streaming
throughput, Need to enable the high streaming
bitmap in the intilization

Signed-off-by: Rahul Gurram <[email protected]>
@ragurram26 ragurram26 force-pushed the Embedded_TA_stack branch from 59bb2ac to fa2d6b6 Compare June 5, 2025 05:27
To support the SiWx917 Multiple TLS version,
Need to enable the SSL version bitmap
in the intilization

Signed-off-by: Rahul Gurram <[email protected]>
Added support for 16K SSL record sizes, which
improves performance for SSL connections
that use larger record sizes

Signed-off-by: Rahul Gurram <[email protected]>
Added support to allocate additional memory for
SSL/TLS connections, typically required for
connections to cloud servers

Signed-off-by: Rahul Gurram <[email protected]>
Added support to Configure number of selects in SiWx917

Signed-off-by: Rahul Gurram <[email protected]>
Added support to Configure number of sockets in SiWx917

Signed-off-by: Rahul Gurram <[email protected]>
@ragurram26 ragurram26 force-pushed the Embedded_TA_stack branch 4 times, most recently from 547fbbc to 623719a Compare June 5, 2025 06:06
This application demonstrates support for SiWx91x
ICMP and DNS protocols

Co-authored-by: Swami Das Nampalli <[email protected]>
Signed-off-by: Swami Das Nampalli <[email protected]>
Signed-off-by: Rahul Gurram <[email protected]>
@ragurram26 ragurram26 force-pushed the Embedded_TA_stack branch from 623719a to c498dcd Compare June 5, 2025 06:15
Copy link

sonarqubecloud bot commented Jun 5, 2025

Copy link

github-actions bot commented Aug 5, 2025

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Aug 5, 2025
@github-actions github-actions bot closed this Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Samples Samples area: Wi-Fi Wi-Fi DNM (manifest) This PR should not be merged (controlled by action-manifest) manifest manifest-hal_silabs platform: Silabs Silicon Labs platform: STM32 ST Micro STM32 Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants