Adding SiWx917 Network Stack Application APIs by ragurram26 · Pull Request #89716 · zephyrproject-rtos/zephyr

ragurram26 · 2025-05-09T09:06:47Z

To support the SiWx917 Network Stack Application
protocol offloading, we need to add the Silicon Labs APIs,
so adding the corresponding source files and include files

github-actions · 2025-05-09T09:09:22Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
hal_silabs	zephyrproject-rtos/hal_silabs@`a0095a7` (`main`)	zephyrproject-rtos/hal_silabs#100	zephyrproject-rtos/hal_silabs#100/files

⛔ DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

jhedberg · 2025-05-09T09:20:28Z

@ragurram26 please provide a more detailed PR & commit message description, explaining the background to this, why this is needed, etc. Also most people in a Zephyr context won't know what "TA" is, so you need to explain that as well. If you're adding new APIs (like the title implies) I'd also expect to see some sample code to demonstrate their usage and provide code coverage for CI.

jhedberg · 2025-05-09T09:21:35Z

One other thing: when you have to enumerate multiple independent changes in a single commit message (like you're doing now), it's a clear indication that you should split this up into multiple commits.

jhedberg · 2025-05-09T09:22:19Z

drivers/wifi/siwx91x/siwx91x_wifi.c

 		net_if_dormant_off(sidev->iface);
 	}
-
+#ifndef CONFIG_WIFI_SILABS_SIWX91X_NET_STACK_OFFLOAD


Could this use if (!IS_ENABLED(CONFIG_WIFI_SILABS_SIWX91X_NET_STACK_OFFLOAD)) {?

ragurram26 · 2025-05-09T10:05:42Z

@jhedberg I have updated the description .

I'd also expect to see some sample code to demonstrate their usage and provide code coverage for CI.
Should we include the application in this pull request, or is there an alternative method to ensure code coverage for continuous integration (CI)?

ragurram26 · 2025-05-30T09:22:50Z

I believe you need to provide examples and to prove the usefulness of these features before to go further.

I have added sample example in this path :samples/boards/siwx91x

jerome-pouiller

This PR is big enough. I would suggest to focus on DNS and ping and see this can be accepted.

jerome-pouiller · 2025-06-03T10:36:34Z

drivers/wifi/siwx91x/Kconfig.siwx91x

+	  SiWx91x series.
+
+config WIFI_SILABS_SIWX91X_SSL_MEMORY_CLOUD
+	bool "Offloaded implementation for the SSL/TLS cloud connections"


Why the issue is specific to cloud servers?

jerome-pouiller · 2025-06-03T10:38:57Z

soc/silabs/silabs_siwx91x/siwg917/nwp.c

+	}
+#ifdef CONFIG_WIFI_SILABS_SIWX91X_SOCKETS
+	boot_config->tcp_ip_feature_bit_map |=
+        SL_SI91X_TCP_IP_TOTAL_SOCKETS(CONFIG_WIFI_SILABS_SIWX91X_TOTAL_SOCKETS);


indentation

jerome-pouiller · 2025-06-03T10:40:56Z

samples/boards/siwx91x/siwx91x_sample_app/README.rst

+Overview
+********
+
+A sample application that demonstrates the DNS client and ICMP functionality.This program will get the IP address


80 columns.

jerome-pouiller · 2025-06-03T10:42:09Z

samples/boards/siwx91x/siwx91x_sample_app/src/app_config.h

+#define PING_PACKET_SIZE 64
+#define PING_PACKETS     30
+
+typedef enum siwx91x_app_state_e {


What is the point of exposing this in the header file?

jerome-pouiller · 2025-06-03T10:43:15Z

samples/boards/siwx91x/siwx91x_sample_app/src/app_config.h

+    struct net_if *iface);
+static void handle_wifi_connect_result(struct net_mgmt_event_callback *cb);
+static sl_status_t network_event_handler(sl_net_event_t event, sl_status_t status, void *data,
+    uint32_t data_length);


What is the point of declaring static (private) functions in public header?

jerome-pouiller · 2025-06-03T10:49:52Z

samples/boards/siwx91x/siwx91x_sample_app/src/main.c

+					  (k_thread_entry_t)application_start, NULL, NULL, NULL,
+					  K_PRIO_PREEMPT(10), 0, K_NO_WAIT);
+
+	k_thread_start(application_tid);


What is a the point of creating a new thread?

jerome-pouiller · 2025-06-03T10:52:09Z

samples/boards/siwx91x/siwx91x_sample_app/src/main.c

+			return;
+		} break;
+		default: {
+			k_sleep(K_MSEC(500));


From a power consumption, latency and software design perspective, this loop event is not a great idea. Please remove it.

jerome-pouiller · 2025-06-03T10:57:33Z

samples/boards/siwx91x/siwx91x_sample_app/src/main.c

+		case SIWX91X_WIFI_CONNECT_STATE: {
+			struct wifi_connect_req_params *cnx_params = NULL;
+
+			cnx_params = malloc(sizeof(struct wifi_connect_req_params));


Any reason why you don't use the stack to allocate this struct?

jerome-pouiller · 2025-06-03T10:58:14Z

samples/boards/siwx91x/siwx91x_sample_app/src/app_config.h

+    };
+} context;
+
+#define WIFI_SHELL_MGMT_EVENTS (NET_EVENT_WIFI_CONNECT_RESULT)


Is this symbol useful?

jerome-pouiller · 2025-06-03T11:02:52Z

samples/boards/siwx91x/siwx91x_sample_app/prj.conf

+CONFIG_NET_DHCPV6=n
+CONFIG_MAIN_STACK_SIZE=2048
+CONFIG_WIFI_SILABS_SIWX91X_PING=y
+CONFIG_WIFI_SILABS_SIWX91X_DNS_CLIENT=y


Can you provide some numbers showing the added value of CONFIG_WIFI_SILABS_SIWX91X_PING and CONFIG_WIFI_SILABS_SIWX91X_DNS_CLIENT compared to the Zephyr native implementation.

To support the SiWx917 SNTP Network Stack Application protocol offloading, we need to integrate the Silicon Labs APIs, so adding the corresponding source files and include files in the kconfig and CMakelist Co-authored-by: Swami Das Nampalli <swami.das@silabs.com> Signed-off-by: Swami Das Nampalli <swami.das@silabs.com> Signed-off-by: Rahul Gurram <rahul.gurram@silabs.com>

To support the SiWx917 HTTP Network Stack Application protocol offloading, we need to integrate the Silicon Labs APIs, so adding the corresponding source files and include files in the kconfig and CMakelist Co-authored-by: Swami Das Nampalli <swami.das@silabs.com> Signed-off-by: Swami Das Nampalli <swami.das@silabs.com> Signed-off-by: Rahul Gurram <rahul.gurram@silabs.com>

To support the SiWx917 MQTT Network Stack Application protocol offloading, we need to integrate the Silicon Labs APIs, so adding the corresponding source files and include files in the kconfig and CMakelist Signed-off-by: Rahul Gurram <rahul.gurram@silabs.com>

To support the SiWx917 ICMP Network Stack Application protocol offloading, we need to integrate the Silicon Labs APIs, so adding the corresponding source files and include files in the kconfig and CMakelist Signed-off-by: Rahul Gurram <rahul.gurram@silabs.com>

To support the SiWx917 Websockets Network Stack Application protocol offloading, we need to integrate the Silicon Labs APIs, so adding the corresponding source files and include files in the kconfig and CMakelist Signed-off-by: Rahul Gurram <rahul.gurram@silabs.com>

To support the SiWx917 MDNS Network Stack Application protocol offloading, we need to integrate the Silicon Labs APIs, so adding the corresponding source files and include files in the kconfig and CMakelist Signed-off-by: Rahul Gurram <rahul.gurram@silabs.com>

To support the SiWx917 DNS Network Stack Application protocol offloading, we need to integrate the Silicon Labs APIs, so adding the corresponding source files and include files in the kconfig and CMakelist Signed-off-by: Rahul Gurram <rahul.gurram@silabs.com>

To support the SiWx917 TLS Sockets , Need to enable the TLS bitmap in the intilization Signed-off-by: Rahul Gurram <rahul.gurram@silabs.com>

To support the SiWx917 Single TLS Sockets, Need to enable the Single TLS bitmap in the intilization Signed-off-by: Rahul Gurram <rahul.gurram@silabs.com>

To support the SiWx917 Three SSL Sockets, Need to enable the Three SSL bitmap in the intilization Signed-off-by: Rahul Gurram <rahul.gurram@silabs.com>

To support the SiWx917 SSL high streaming throughput, Need to enable the high streaming bitmap in the intilization Signed-off-by: Rahul Gurram <rahul.gurram@silabs.com>

To support the SiWx917 Multiple TLS version, Need to enable the SSL version bitmap in the intilization Signed-off-by: Rahul Gurram <rahul.gurram@silabs.com>

Added support for 16K SSL record sizes, which improves performance for SSL connections that use larger record sizes Signed-off-by: Rahul Gurram <rahul.gurram@silabs.com>

Added support to allocate additional memory for SSL/TLS connections, typically required for connections to cloud servers Signed-off-by: Rahul Gurram <rahul.gurram@silabs.com>

Added support to Configure number of selects in SiWx917 Signed-off-by: Rahul Gurram <rahul.gurram@silabs.com>

Added support to Configure number of sockets in SiWx917 Signed-off-by: Rahul Gurram <rahul.gurram@silabs.com>

This application demonstrates support for SiWx91x ICMP and DNS protocols Co-authored-by: Swami Das Nampalli <swami.das@silabs.com> Signed-off-by: Swami Das Nampalli <swami.das@silabs.com> Signed-off-by: Rahul Gurram <rahul.gurram@silabs.com>

sonarqubecloud · 2025-06-05T06:39:50Z

Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2025-08-05T00:43:34Z

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

github-actions bot added area: Wi-Fi Wi-Fi platform: Silabs Silicon Labs labels May 9, 2025

github-actions bot requested review from Kludentwo, MaochenWang1, Martinhoff-maker, asmellby, jerome-pouiller, jhedberg, jukkar, krish2718, mnkp, rettichschnidi, rlubos and yonsch May 9, 2025 09:07

github-actions bot assigned jhedberg and asmellby May 9, 2025

ragurram26 force-pushed the Embedded_TA_stack branch from 3f908db to 8d5e691 Compare May 9, 2025 09:07

github-actions bot added manifest manifest-hal_silabs DNM (manifest) This PR should not be merged (controlled by action-manifest) labels May 9, 2025

ragurram26 changed the title ~~Adding SL Embedded TA APIs~~ Adding Silabs Embedded TA APIs May 9, 2025

jhedberg reviewed May 9, 2025

View reviewed changes

ragurram26 changed the title ~~Adding Silabs Embedded TA APIs~~ Adding Silabs Embedded SiWx917 APIs May 9, 2025

ragurram26 force-pushed the Embedded_TA_stack branch from 8d5e691 to 8b9c083 Compare May 9, 2025 10:01

ragurram26 force-pushed the Embedded_TA_stack branch from 8b9c083 to 6966645 Compare May 9, 2025 10:10

rettichschnidi removed their request for review May 12, 2025 07:40

ragurram26 force-pushed the Embedded_TA_stack branch 9 times, most recently from b4e40e2 to 0c25983 Compare May 29, 2025 09:58

jerome-pouiller reviewed Jun 3, 2025

View reviewed changes

ragurram26 and others added 17 commits June 5, 2025 10:51

drivers: wifi: siwx91x: Adding TLS bitmap

4395102

To support the SiWx917 TLS Sockets , Need to enable the TLS bitmap in the intilization Signed-off-by: Rahul Gurram <rahul.gurram@silabs.com>

drivers: wifi: siwx91x: Adding Single TLS bitmap

20e57f6

To support the SiWx917 Single TLS Sockets, Need to enable the Single TLS bitmap in the intilization Signed-off-by: Rahul Gurram <rahul.gurram@silabs.com>

drivers: wifi: siwx91x: Adding Three SSL bitmap

7dd74f8

To support the SiWx917 Three SSL Sockets, Need to enable the Three SSL bitmap in the intilization Signed-off-by: Rahul Gurram <rahul.gurram@silabs.com>

drivers: wifi: siwx91x: Adding SSL bitmap

175cdc8

To support the SiWx917 SSL high streaming throughput, Need to enable the high streaming bitmap in the intilization Signed-off-by: Rahul Gurram <rahul.gurram@silabs.com>

drivers: wifi: siwx91x: Muliple TLS version

69fed9c

To support the SiWx917 Multiple TLS version, Need to enable the SSL version bitmap in the intilization Signed-off-by: Rahul Gurram <rahul.gurram@silabs.com>

drivers: wifi: siwx91x: SSL 16k record

a4e0856

Added support for 16K SSL record sizes, which improves performance for SSL connections that use larger record sizes Signed-off-by: Rahul Gurram <rahul.gurram@silabs.com>

drivers: wifi: siwx91x: Adding SSL cloud memory

3278e41

Added support to allocate additional memory for SSL/TLS connections, typically required for connections to cloud servers Signed-off-by: Rahul Gurram <rahul.gurram@silabs.com>

drivers: wifi: siwx91x: Adding select bitmap

c8f938a

Added support to Configure number of selects in SiWx917 Signed-off-by: Rahul Gurram <rahul.gurram@silabs.com>

drivers: wifi: siwx91x: Configure sockets

1ea219f

Added support to Configure number of sockets in SiWx917 Signed-off-by: Rahul Gurram <rahul.gurram@silabs.com>

samples: boards : Wi-Fi SiWx91x sample app

c498dcd

This application demonstrates support for SiWx91x ICMP and DNS protocols Co-authored-by: Swami Das Nampalli <swami.das@silabs.com> Signed-off-by: Swami Das Nampalli <swami.das@silabs.com> Signed-off-by: Rahul Gurram <rahul.gurram@silabs.com>

Conversation

ragurram26 commented May 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jhedberg commented May 9, 2025

Uh oh!

jhedberg commented May 9, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ragurram26 commented May 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ragurram26 commented May 30, 2025

Uh oh!

jerome-pouiller left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Jun 5, 2025

Quality Gate passed

Uh oh!

github-actions bot commented Aug 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ragurram26 commented May 9, 2025 •

edited

Loading

github-actions bot commented May 9, 2025 •

edited

Loading

ragurram26 commented May 9, 2025 •

edited

Loading