Skip to content

soc: stm32: Defaults to "stm32f401xe" when SOC_STM32F401XD selected #89846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

soc: stm32: Defaults to "stm32f401xe" when SOC_STM32F401XD selected #89846

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion soc/st/stm32/stm32f4x/Kconfig.soc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ config SOC_STM32F479XX

config SOC
default "stm32f401xc" if SOC_STM32F401XC
default "stm32f401xd" if SOC_STM32F401XD
default "stm32f401xe" if SOC_STM32F401XD
Copy link
Contributor

@nordicjm nordicjm May 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, the name must match the symbol

Copy link
Contributor Author

@rriveramcrus rriveramcrus May 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, the name must match the symbol

@nordicjm can you elaborate on this comment? That doesn't seem to be explicitly true for, let's say, soc/nordic/nrf52/Kconfig.soc.

zephyrproject-rtos/hal_stm32#276
Some additional context around this draft PR.

Copy link
Contributor

@nordicjm nordicjm May 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name must match the symbol

default "stm32f401xe" if SOC_STM32F401XE
default "stm32f405xx" if SOC_STM32F405XX
default "stm32f407xx" if SOC_STM32F407XE
Expand Down
Loading