-
Notifications
You must be signed in to change notification settings - Fork 8k
drivers: watchdog: Add watchdog driver support on Renesas RX130 #89914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
a212107
to
96b1cbe
Compare
96b1cbe
to
c588074
Compare
c588074
to
e0de9ec
Compare
|
e0de9ec
to
832a917
Compare
31663c3
to
3c889d2
Compare
3c889d2
to
13c3a7f
Compare
13c3a7f
to
adc5995
Compare
#elif defined(CONFIG_WDT_RENESAS_RX_IWDT) | ||
#define WDT_SETUP_FLAGS 0 | ||
#define WDT_TIMEOUT K_MSEC(WDT_TIMEOUT_VALUE) | ||
#define SLEEP_TIME K_MSEC(CONFIG_TEST_WDT_SLEEP_TIME) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hard-coding platform-specific defines inside of generic tests should really be avoided if at all possible.
Ideally for this kind of test, there would be local Kconfig options that are overridden on a per board basis, in boards/<board>.conf
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated the source using Kconfig options for setup flag. Could you please take a look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this (or possibly another) PR adjust the samples/drivers/watchdog
to support local Kconfig options instead of hard-coding platform specific defines inside of the source file?
This change ensure .noinit is excluded from zeroed memory region after reset Signed-off-by: Quy Tran <[email protected]>
OFS values setting for RXv1/RXv2 will be defined in SOC Kconfig and set in vects.c file Signed-off-by: Quy Tran <[email protected]>
Add support for non-maskable interrupt (NMI) vector table for Renesas RX architecture Signed-off-by: Sang Tran <[email protected]>
Add initial support for independent watchdog driver for Renesas RX with r_iwdt_rx RDP HAL Signed-off-by: Sang Tran <[email protected]>
Add iwdt property node on dts for watchdog driver Signed-off-by: Quy Tran <[email protected]>
Enables OSF0 register select for IWDT driver setting on start mode Signed-off-by: Quy Tran <[email protected]>
Enable iwdt dts nodes and iwdtsclk clock on RSK-RX130-512kb Signed-off-by: Quy Tran <[email protected]>
0469cef
adc5995
to
0469cef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please avoid mixing formatting changes with functional ones in the same commit, and avoid formatting changes completely if they are not required for CI.
…eout Replace hard-coded platform definrs with Kconfig marcos Signed-off-by: Quy Tran <[email protected]>
0469cef
to
5dff3e2
Compare
|
Add watchdog driver support on RSK-RX130@512kb (Independent Watchdog Timer).
Users can the counter by 2 modes (select by WDT_RENESAS_RX_IWDT_REGISTER_START_MODE or WDT_RENESAS_RX_IWDT_AUTO_START_MODE)