Skip to content

Conversation

quytranpzz
Copy link
Contributor

@quytranpzz quytranpzz commented May 14, 2025

Add watchdog driver support on RSK-RX130@512kb (Independent Watchdog Timer).

Users can the counter by 2 modes (select by WDT_RENESAS_RX_IWDT_REGISTER_START_MODE or WDT_RENESAS_RX_IWDT_AUTO_START_MODE)

  • Auto-start mode: controlled by option function select register 0 (OFS0).
  • Register start mode: controlled by the IWDT registers

Copy link

github-actions bot commented May 14, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@github-actions github-actions bot added manifest manifest-hal_renesas DNM (manifest) This PR should not be merged (controlled by action-manifest) labels May 14, 2025
@quytranpzz quytranpzz force-pushed the rx_zephyr_wdt_support branch 2 times, most recently from a212107 to 96b1cbe Compare May 14, 2025 15:26
@quytranpzz quytranpzz force-pushed the rx_zephyr_wdt_support branch from 96b1cbe to c588074 Compare May 22, 2025 15:24
@quytranpzz quytranpzz marked this pull request as ready for review May 22, 2025 15:39
@quytranpzz quytranpzz marked this pull request as draft May 22, 2025 15:40
@quytranpzz quytranpzz marked this pull request as ready for review May 22, 2025 15:41
@quytranpzz quytranpzz force-pushed the rx_zephyr_wdt_support branch from c588074 to e0de9ec Compare June 10, 2025 04:55
@github-actions github-actions bot added the area: Samples Samples label Jun 10, 2025
@github-actions github-actions bot requested a review from kartben June 10, 2025 04:55
Copy link

@duynguyenxa duynguyenxa added the platform: Renesas RX Renesas Electronics Corp, RX label Jul 25, 2025
@quytranpzz quytranpzz force-pushed the rx_zephyr_wdt_support branch from 31663c3 to 3c889d2 Compare September 22, 2025 04:50
duynguyenxa
duynguyenxa previously approved these changes Sep 23, 2025
thenguyenyf
thenguyenyf previously approved these changes Sep 25, 2025
duynguyenxa
duynguyenxa previously approved these changes Sep 29, 2025
Comment on lines 30 to 33
#elif defined(CONFIG_WDT_RENESAS_RX_IWDT)
#define WDT_SETUP_FLAGS 0
#define WDT_TIMEOUT K_MSEC(WDT_TIMEOUT_VALUE)
#define SLEEP_TIME K_MSEC(CONFIG_TEST_WDT_SLEEP_TIME)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard-coding platform-specific defines inside of generic tests should really be avoided if at all possible.

Ideally for this kind of test, there would be local Kconfig options that are overridden on a per board basis, in boards/<board>.conf.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the source using Kconfig options for setup flag. Could you please take a look?

Copy link
Member

@cfriedt cfriedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this (or possibly another) PR adjust the samples/drivers/watchdog to support local Kconfig options instead of hard-coding platform specific defines inside of the source file?

quytranpzz and others added 7 commits October 7, 2025 08:44
This change ensure .noinit is excluded from zeroed memory region after
reset

Signed-off-by: Quy Tran <[email protected]>
OFS values setting for RXv1/RXv2 will be defined in SOC
Kconfig and set in vects.c file

Signed-off-by: Quy Tran <[email protected]>
Add support for non-maskable interrupt (NMI)  vector table for
Renesas RX architecture

Signed-off-by: Sang Tran <[email protected]>
Add initial support for independent watchdog driver for Renesas RX
with r_iwdt_rx RDP HAL

Signed-off-by: Sang Tran <[email protected]>
Add iwdt property node on dts for watchdog driver

Signed-off-by: Quy Tran <[email protected]>
Enables OSF0 register select for IWDT driver setting on start mode

Signed-off-by: Quy Tran <[email protected]>
Enable iwdt dts nodes and iwdtsclk clock on RSK-RX130-512kb

Signed-off-by: Quy Tran <[email protected]>
@quytranpzz quytranpzz dismissed stale reviews from duynguyenxa and thenguyenyf via 0469cef October 7, 2025 09:51
@quytranpzz quytranpzz force-pushed the rx_zephyr_wdt_support branch from adc5995 to 0469cef Compare October 7, 2025 09:51
@zephyrbot zephyrbot added area: Boards/SoCs area: Tests Issues related to a particular existing or missing test area: Devicetree Bindings labels Oct 7, 2025
Copy link
Contributor

@JarmouniA JarmouniA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid mixing formatting changes with functional ones in the same commit, and avoid formatting changes completely if they are not required for CI.

…eout

Replace hard-coded platform definrs with Kconfig marcos

Signed-off-by: Quy Tran <[email protected]>
Copy link

sonarqubecloud bot commented Oct 7, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants