posix: clock: fix maybe-uninitialized warning in z_clock_gettime #89928
Conversation
kartben
added
the
Hotfix
|
@cfriedt any chance you could also look into the other issue please? Setting |
github-actions
bot
added
area: POSIX
lib/posix/options/clock_common.c
Outdated
| int z_clock_gettime(clockid_t clock_id, struct timespec *ts) | ||
| { | ||
| struct timespec base; | ||
| struct timespec base = {0}; |
There was a problem hiding this comment.
This made L66 and 67 unnecessary, should we remove them?
There was a problem hiding this comment.
I would agree with that - can you make that change, @kartben?
Monotonic is a bit of a hot path, so removing the additional 2+ memory writes would be a good thing.
There was a problem hiding this comment.
I would move 66-67 before the switch, keep it explicit
There was a problem hiding this comment.
66-67 shouldn't be needed with the variable initialized.
There was a problem hiding this comment.
please check the updated fix
That's a good short-term solution. I can make that change shortly. I think the issue is that some libc functions use POSIX functions (maybe indirectly?). Mentioned in #89068 as well. Long term, I think it would be great to move some things into native Zephyr code. |
Compiler gets confused and thinks base may be used uninitialized. This shouldn't be possible, but to make the warning go away, initialize it. Signed-off-by: Benjamin Cabé <[email protected]>
kartben
force-pushed
the
clock_common_ci_fix
branch
from
f075a5e to
552e900
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
Compiler gets confused and thinks base may be used uninitialized. This shouldn't be possible, but to make the warning go away, initialize it.
Fixes CI issue in main https://github.com/zephyrproject-rtos/zephyr/actions/runs/15014534061/job/42189411225