tests: Bluetooth: Audio: Add RX check for each stream #89971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thalley
force-pushed
the
bap_bsim_rx_each_stream
branch
2 times, most recently
from
ad516c3 to
e01eaf4
Compare
github-actions
bot
added
area: Bluetooth Audio
platform: nRF BSIM
github-actions
bot
requested review from
Casper-Bonde-Bose,
MariuszSkamra,
aescolar,
asbjornsabo,
babrsn,
fredrikdanebjer,
jhedberg,
jthm-ot,
larsgk,
niym-ot,
pin-zephyr and
sjanc
Thalley
force-pushed
the
bap_bsim_rx_each_stream
branch
from
e01eaf4 to
05c84de
Compare
Thalley
force-pushed
the
bap_bsim_rx_each_stream
branch
from
05c84de to
d1a2d50
Compare
Thalley
force-pushed
the
bap_bsim_rx_each_stream
branch
from
d1a2d50 to
9d06da1
Compare
Thalley
force-pushed
the
bap_bsim_rx_each_stream
branch
from
9d06da1 to
7a5dd2f
Compare
Thalley
force-pushed
the
bap_bsim_rx_each_stream
branch
from
7a5dd2f to
48b86e5
Compare
larsgk
previously approved these changes
Aug 14, 2025
Thalley
force-pushed
the
bap_bsim_rx_each_stream
branch
from
48b86e5 to
d01e717
Compare
Thalley
force-pushed
the
bap_bsim_rx_each_stream
branch
2 times, most recently
from
4df0389 to
d533d2b
Compare
Thalley
requested review from
Copilot and
larsgk
and removed request for
pin-zephyr
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the audio test framework to improve stream validation by changing from a global audio received flag to per-stream flags. This enables verification that each individual stream receives expected data rather than just confirming that any stream has received data.
- Move
flag_audio_receivedfrom global scope to per-stream withinaudio_test_streamstruct - Update all test files to use per-stream flags and implement
wait_for_data()functions that check each streaming stream - Extract common streaming check logic into shared utility functions in
bap_common.c
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| common.h/common.c | Remove global flag_audio_received and add per-stream flag to audio_test_stream struct |
| bap_common.h/bap_common.c | Add utility functions for checking if streams are in streaming state |
| bap_stream_rx.c | Update receive callback to set per-stream flag instead of global flag |
| bap_stream_tx.c | Replace local streaming check with shared utility function |
| Multiple test files | Replace global flag usage with per-stream flags and add wait_for_data() functions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Thalley
force-pushed
the
bap_bsim_rx_each_stream
branch
from
d533d2b to
f144ecf
Compare
larsgk
previously approved these changes
Sep 1, 2025
Thalley
force-pushed
the
bap_bsim_rx_each_stream
branch
2 times, most recently
from
0d890c1 to
7b94108
Compare
|
Fixed build issue after #85642 was merged |
Thalley
force-pushed
the
bap_bsim_rx_each_stream
branch
from
7b94108 to
4f8dc06
Compare
Thalley
force-pushed
the
bap_bsim_rx_each_stream
branch
from
4f8dc06 to
60423ea
Compare
Thalley
force-pushed
the
bap_bsim_rx_each_stream
branch
from
60423ea to
98bb021
Compare
zephyrbot
added
the
area: Tests
|
Test fails due to known assertion (#82399) |
Changed the generic global flag_audio_received flag to exist for each stream. This will help verify that each stream, if configured for RX, receives the expected data. One test started failing due to this, so that was disabled until a fix is in place in the controller. Signed-off-by: Emil Gydesen <[email protected]>
Thalley
force-pushed
the
bap_bsim_rx_each_stream
branch
from
98bb021 to
6f8417b
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the generic global flag_audio_received flag to exist for each stream. This will help verify that each stream, if configured for RX, receives the expected data.