[Backport v3.7-branch] drivers: watchdog: npcx: fix T0 timer reload procedure #89983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvsun
approved these changes
May 27, 2025
MulinChao
approved these changes
May 29, 2025
TomChang19
approved these changes
Jun 18, 2025
The correct procedure to reload the T0 timer is:
1. Load TWDT0 register with the new value or write 1 to RST bit in
T0CSR register to load the old value.
2. Wait until RST bit in T0CSR register becomes 1.
3. Wait until RST bit in T0CSR register becomes 0.
The current watchdog driver misses step 2.
Fix the issue in this commit.
Signed-off-by: Jun Lin <[email protected]>
(cherry picked from commit 6c3b617)
nashif
force-pushed
the
backport-85712-to-v3.7-branch
branch
from
f1cadf7 to
f63ec0f
Compare
github-actions
bot
added
platform: Nuvoton NPCX
github-actions
bot
requested review from
fabiobaltieri,
jackrosenthal,
katsuster,
keith-zephyr,
martinjaeger and
sjg20
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 6c3b617 from #85712.
Fixes #89984