CMSIS 6 update #90063
Merged
CMSIS 6 update #90063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: ARM
github-actions
bot
requested review from
bbolen,
carlocaione,
danieldegrasse,
dkalowsk,
galak,
ithinuel,
kartben,
MaureenHelm,
microbuilder and
stephanosio
wearyzen
force-pushed
the
cmsis_6_rel
branch
2 times, most recently
from
bec0c84 to
d704598
Compare
|
@aescolar and @fabiobaltieri this PR is a follow up of the discussion in #89370, could you please have a look and let me know your thoughts? |
wearyzen
force-pushed
the
cmsis_6_rel
branch
2 times, most recently
from
e89bc7e to
bbca24d
Compare
fabiobaltieri
previously approved these changes
May 19, 2025
Add a note to announce the switch to CMSIS_6 for Cortex-M arch. Signed-off-by: Sudan Landge <[email protected]>
As noted in PR zephyrproject-rtos#89370, the content of these files falls below the trivial threshold. Therefore, it is not necessary to retain the original copyright, which was carried over when the files were copied from the `cmsis` module. Signed-off-by: Sudan Landge <[email protected]>
Zephyr switched to using CMSIS_6 module in f726cb5 which breaks certain boards like `nucleo_h745zi_q/stm32h745xx/m7` when CONFIG_CORTEX_M_DWT, CONFIG_TIMING_FUNCTIONS are enabled and cmsis from `module/hal/cmsis` is not available (deleted explicitly after west update). This commit adds a provision to be able to use CMSIS_6 macros when the module cmsis is not available. Signed-off-by: Sudan Landge <[email protected]>
aescolar
approved these changes
May 20, 2025
|
fabiobaltieri
approved these changes
May 20, 2025
dkalowsk
approved these changes
May 23, 2025
|
|
||
| * Cortex-M boards/socs now require the ``CMSIS_6`` module to build properly (instead of ``cmsis`` | ||
| which was CMSIS 5.9.0). | ||
| If trying to build a Cortex-M board, do a ``west update`` to make sure that ``CMSIS_6`` module is |
There was a problem hiding this comment.
minor suggestion, not a blocker to merge though
Before building a Cortex-M board, run west update to ensure that the CMSIS_6 module is...
| If trying to build a Cortex-M board, do a ``west update`` to make sure that ``CMSIS_6`` module is | ||
| available before running ``west build`` or other commands. | ||
|
|
||
| Boards or SOCs or modules using the older ``cmsis`` module either with a local copy or via the |
There was a problem hiding this comment.
Boards, SOCs, or modules using the older...
|
|
||
| Boards or SOCs or modules using the older ``cmsis`` module either with a local copy or via the | ||
| :kconfig:option:`CONFIG_ZEPHYR_CMSIS_MODULE_DIR` are requested to move to the ``CMSIS_6`` module | ||
| which can be accessed via the :kconfig:option:`CONFIG_ZEPHYR_CMSIS_6_MODULE_DIR` configuration. |
There was a problem hiding this comment.
should there be a line adding when the deprecation of CMSIS 5 for Cortex-M projects is expected?
There was a problem hiding this comment.
I am not sure when this would happen since we request the HAL owners to move to CMSIS_6 but its really up to them when to actually do this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update release notes to announce the switch to CMSIS_6 for Cortex-M arch.
This also includes follow up changes discussed as part of PR #89370.