drivers: gpio: nrfx: Add support for GPIOTE0 on nrf54h20 cpurad #91041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
anangl,
henrikbrixandersen,
hubertmis,
jaz1-nordic,
kl-cruz,
magp-nordic,
masz-nordic,
mnkp and
nika-nordic
|
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
github-actions
bot
added
manifest
manifest-hal_nordic
DNM (manifest)
|
Hey, this needs a rebase and force push to pick up the CI error workaround. (the twister one anyway) |
nordic-krch
force-pushed
the
nrf54h20_rad_gpiote
branch
from
7dfc940 to
7484e74
Compare
kl-cruz
previously approved these changes
Jun 12, 2025
nordic-krch
force-pushed
the
nrf54h20_rad_gpiote
branch
from
7484e74 to
5b050f2
Compare
nordic-krch
force-pushed
the
nrf54h20_rad_gpiote
branch
2 times, most recently
from
d979dc4 to
fd196ed
Compare
nordic-krch
force-pushed
the
nrf54h20_rad_gpiote
branch
from
fd196ed to
7fb0fee
Compare
kl-cruz
previously approved these changes
Jul 18, 2025
nordic-krch
force-pushed
the
nrf54h20_rad_gpiote
branch
from
7fb0fee to
4189576
Compare
kl-cruz
force-pushed
the
nrf54h20_rad_gpiote
branch
from
4189576 to
97faa04
Compare
github-actions
bot
removed
manifest-hal_nordic
DNM (manifest)
Bump required version of nrf-regtool to 9.2.0. Signed-off-by: Krzysztof Chruściński <[email protected]>
Add GPIOTE0 instance in radio peripherals. Signed-off-by: Krzysztof Chruściński <[email protected]>
Add new feature flags to gpiote node. Include pinctrl. Pins used by GPIOTE0 on nrf54h20/cpurad require CTRLSEL configuration. Pins are listed using pinctrl and parsed by nrf-regtool to prepare UICR configuration. Signed-off-by: Krzysztof Chruściński <[email protected]>
Add NRFX_GPIOTE_VAR_FEATURE_SUPPORT feature flag to nrfx configuration. It enables support for special GPIOTE0 instance in nrfx_gpiote driver. Signed-off-by: Krzysztof Chruściński <[email protected]>
Add support for special GPIOTE0 instance on nrf54h20/cpurad. This instance requires special handling because: - there is no support for PORT event (level interrupts) - TE channels are fixed to the pin Signed-off-by: Krzysztof Chruściński <[email protected]>
Add return code checking for gpio_pin_interrupt_configure functions. Add disabling pin interrupt at the end of the test to restore pin state. Signed-off-by: Krzysztof Chruściński <[email protected]>
Add configuration for testing GPIOTE0 instance on nrf54h20/cpurad. Signed-off-by: Krzysztof Chruściński <[email protected]>
bjarki-andreasen
force-pushed
the
nrf54h20_rad_gpiote
branch
from
97faa04 to
c04e127
Compare
|
Rebased |
Comment on lines
+415
to
+423
| gpiote0: gpiote@27000 { | ||
| compatible = "nordic,nrf-gpiote"; | ||
| reg = <0x27000 0x1000>; | ||
| status = "disabled"; | ||
| interrupts = <39 NRF_DEFAULT_IRQ_PRIORITY>; | ||
| instance = <0>; | ||
| no-port-event; | ||
| fixed-channels-supported; | ||
| }; |
There was a problem hiding this comment.
Adding this node causes this check in validate_base_addresses.c to fail for us, since in our case the MDK only defines NRF_RADIOCORE_GPIOTE and not NRF_GPIOTE or NRF_GPIOTE0:
zephyr/soc/nordic/validate_base_addresses.c
Line 186 in d53f324
Would it be possible to add something like
#if !defined(NRF_GPIOTE0) && defined(NRF_RADIOCORE_GPIOTE)
#define NRF_GPIOTE0 NRF_RADIOCORE_GPIOTE
#endifto validate_base_addresses.c?
There was a problem hiding this comment.
@nordic-krch - will you be able to address this comment?
There was a problem hiding this comment.
@nordic-krch is on vacation, I have pushed the suggestion
nika-nordic
previously approved these changes
Jul 31, 2025
bjarki-andreasen
previously approved these changes
Jul 31, 2025
Map definition of NRF_GPIOTE0 to NRF_RADIOCORE_GPIOTE when MDK defines NRF_RADIOCORE_GPIOTE instead of NRF_GPIOTE0 Signed-off-by: Bjarki Arge Andreasen <[email protected]>
bjarki-andreasen
dismissed stale reviews from nika-nordic and themself
via
d1de673
|
|
@anangl can you take a look? |
bjarki-andreasen
approved these changes
Aug 6, 2025
nika-nordic
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for special GPIOTE0 instance on nrf54h20/cpurad.
This instance requires special handling because:
DNMuntilnrf-regtoolv9.2.0 is available.