drivers: display: Introduce ST7565R #91320

giyorah · 2025-06-09T17:05:56Z

Introduce support for Sitronix's ST7565R display controller.
Tested on JHD12864 LCD display.

JarmouniA

A node is needed in tests/drivers/build_all/display/app.overlay to build controller code in CI.

drivers/display/display_st7565r.h

drivers/display/display_st7565r.c

faxe1008 · 2025-06-09T19:18:44Z

drivers/display/display_st7565r.c

+
+	/* Configure data_cmd pin if specified */
+	if (config->data_cmd.port &&
+	    gpio_pin_configure_dt(&config->data_cmd, GPIO_OUTPUT_INACTIVE) < 0) {


Combine those statement with the previous one

drivers/display/display_st7565r.c

faxe1008 · 2025-06-09T19:22:09Z

drivers/display/display_st7565r.c

+{
+	const struct st7565r_config *config = dev->config;
+	uint8_t zero_buf[config->width];
+	memset(zero_buf, 0, sizeof(zero_buf));


can be combined with previous statement = {0}

Width does come from a static value in the devicetree. However, since config->width is a runtime value, zero_buf is considered a variable length array, which can't be initialized with = {0}. I'll have to stick with the memset call here.

henrikbrixandersen

Review comments needs to be resolved, not just marked as resolved.

drivers/display/display_st7565r.c

sonarqubecloud · 2025-06-13T02:25:42Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

addressed

dts/bindings/display/sitronix,st7565r.yaml

drivers/display/display_st7565r.h

drivers/display/display_st7565r.c

GENMASK() review comment addressed.

i believe my comments to date have been addressed - thanks!

giyorah · 2025-07-28T08:03:29Z

@kartben @JarmouniA ping. Can it be merged?

drivers/display/display_st7565r.c

dts/bindings/display/sitronix,st7565r.yaml

drivers/display/Kconfig.st7565r

Copilot

Pull Request Overview

Introduces support for the Sitronix ST7565R display controller driver, a dot matrix LCD controller that communicates over SPI. This adds comprehensive driver implementation with device tree bindings for configuration and test infrastructure.

Adds complete ST7565R driver implementation with SPI communication support
Provides device tree bindings with configurable LCD properties (bias, power control, booster ratio)
Includes build system integration and test overlay configuration

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
drivers/display/display_st7565r.c	Main driver implementation with initialization, display operations, and SPI communication
drivers/display/display_st7565r.h	Command definitions and constants for ST7565R controller
dts/bindings/display/sitronix,st7565r.yaml	Device tree binding specification with configuration properties
drivers/display/Kconfig.st7565r	Kconfig configuration for ST7565R driver
drivers/display/Kconfig	Integration of ST7565R Kconfig into main display configuration
drivers/display/CMakeLists.txt	Build system integration for ST7565R driver
tests/drivers/build_all/display/app.overlay	Test configuration overlay for build verification

drivers/display/display_st7565r.c

Copilot · 2025-07-31T06:33:28Z

drivers/display/display_st7565r.c

+	/* Specify timeout as an absolute time since system boot */
+	k_sleep(K_TIMEOUT_ABS_MS(config->ready_time_ms));


Using K_TIMEOUT_ABS_MS() for a delay is incorrect. This function expects an absolute timestamp since boot, not a relative delay. Use K_MSEC(config->ready_time_ms) instead for a relative delay.

Suggested change

/* Specify timeout as an absolute time since system boot */

k_sleep(K_TIMEOUT_ABS_MS(config->ready_time_ms));

/* Specify timeout as a relative delay in milliseconds */

k_sleep(K_MSEC(config->ready_time_ms));

This is intentional. ready-time-ms: time in milliseconds to wait before initializing the controller after power-on.

.

giyorah · 2025-10-08T16:54:30Z

Commenting to have the stale label removed.

henrikbrixandersen · 2025-10-08T17:33:27Z

Rebased on main and resolve CI issue.

kartben · 2025-10-08T18:38:50Z

Rebased on main and resolve CI issue.

Well CI issue was the runner crashing so trying to re-run it, let's see how this goes

giyorah · 2025-10-09T17:34:48Z

Rebased on main and resolve CI issue.

Well CI issue was the runner crashing so trying to re-run it, let's see how this goes

Thanks, @kartben.

I see that it still fails (specifically, the 'twister-build-prep' job). Something to do with ModuleNotFoundError: No module named 'jsonschema'. Is there a way around this?

kartben · 2025-10-09T19:15:01Z

Rebased on main and resolve CI issue.

Well CI issue was the runner crashing so trying to re-run it, let's see how this goes

Thanks, @kartben.

I see that it still fails (specifically, the 'twister-build-prep' job). Something to do with ModuleNotFoundError: No module named 'jsonschema'. Can I run it locally or something? Is there a way around this?

please rebase your branch on main (and then force push) -- this will do the trick!

kartben · 2025-10-09T19:40:23Z

@giyorah

git reset bc78471694aed8447d3d73a999b8df47eceec183 --hard
git rebase origin/main
git push origin --force

(assuming that you have your fork repo named origin)

Introduce support for Sitronix's ST7565R display controller. Tested on JHD12864 LCD display. Signed-off-by: Giyora Haroon <[email protected]>

JarmouniA · 2025-10-11T14:02:18Z

drivers/display/display_st7565r.h

Separate header file is not needed.

JarmouniA · 2025-10-11T14:03:42Z

drivers/display/display_st7565r.c

+	.set_pixel_format = st7565r_set_pixel_format,
+};
+
+#define DT_DRV_COMPAT sitronix_st7565r


Put this at the beginning of the file so it's easily found.

JarmouniA · 2025-10-11T14:04:25Z

drivers/display/display_st7565r.c

+
+#define DT_DRV_COMPAT sitronix_st7565r
+
+#if DT_NUM_INST_STATUS_OKAY(DT_DRV_COMPAT) == 0


Not needed, Kconfig takes care of this with depends on DT_HAS_SITRONIX_ST7565R_ENABLED

JarmouniA · 2025-10-11T14:13:52Z

dts/bindings/display/sitronix,st7565r.yaml

+# Copyright (c) 2025, Giyora Haroon
+# SPDX-License-Identifier: Apache-2.0
+
+title: Sitronix ST7565R dot matrix LCD controller (SPI)


Suggested change

title: Sitronix ST7565R dot matrix LCD controller (SPI)

title: ST7565R LCD controller (SPI)

Non-blocking

github-actions bot added the area: Display label Jun 9, 2025

github-actions bot requested review from JarmouniA, VynDragon, danieldegrasse and jfischer-no June 9, 2025 17:06

JarmouniA requested changes Jun 9, 2025

View reviewed changes

faxe1008 reviewed Jun 9, 2025

View reviewed changes

giyorah force-pushed the st7565r branch from f357d7f to 34c4b01 Compare June 10, 2025 20:44

giyorah requested review from JarmouniA and faxe1008 June 10, 2025 20:56

henrikbrixandersen previously requested changes Jun 10, 2025

View reviewed changes

giyorah force-pushed the st7565r branch from 34c4b01 to af05d01 Compare June 11, 2025 22:25

giyorah requested a review from henrikbrixandersen June 11, 2025 22:33

JarmouniA previously requested changes Jun 11, 2025

View reviewed changes

drivers/display/display_st7565r.c Outdated Show resolved Hide resolved

giyorah force-pushed the st7565r branch from af05d01 to dcc15b3 Compare June 13, 2025 02:00

giyorah requested a review from JarmouniA June 13, 2025 02:04

kartben previously requested changes Jun 13, 2025

View reviewed changes

dts/bindings/display/sitronix,st7565r.yaml Show resolved Hide resolved

drivers/display/display_st7565r.h Outdated Show resolved Hide resolved

drivers/display/display_st7565r.c Outdated Show resolved Hide resolved

drivers/display/display_st7565r.c Show resolved Hide resolved

giyorah force-pushed the st7565r branch from dcc15b3 to d2150d0 Compare July 17, 2025 20:40

giyorah requested a review from kartben July 17, 2025 20:44

JarmouniA previously requested changes Jul 28, 2025

View reviewed changes

giyorah force-pushed the st7565r branch from d2150d0 to acd58f0 Compare July 31, 2025 05:31

giyorah requested a review from JarmouniA July 31, 2025 05:35

kartben requested a review from Copilot July 31, 2025 06:32

Copilot AI reviewed Jul 31, 2025

View reviewed changes

github-actions bot added the Stale label Oct 7, 2025

henrikbrixandersen removed the Stale label Oct 8, 2025

kartben closed this Oct 8, 2025

kartben reopened this Oct 8, 2025

zephyrbot added area: Tests Issues related to a particular existing or missing test area: Boards/SoCs area: Devicetree Bindings labels Oct 8, 2025

zephyrbot requested a review from nashif October 8, 2025 18:39

zephyrbot assigned nashif Oct 8, 2025

nashif removed their assignment Oct 9, 2025

nashif previously approved these changes Oct 9, 2025

View reviewed changes

zephyrbot assigned nashif Oct 9, 2025

giyorah dismissed stale reviews from nashif and JarmouniA via bc78471 October 11, 2025 13:45

giyorah force-pushed the st7565r branch from 0de0710 to bc78471 Compare October 11, 2025 13:45

drivers: display: Introduce ST7565R

58762f9

Introduce support for Sitronix's ST7565R display controller. Tested on JHD12864 LCD display. Signed-off-by: Giyora Haroon <[email protected]>

zephyrproject-rtos deleted a comment from kartben Oct 11, 2025

JarmouniA requested changes Oct 11, 2025

View reviewed changes

giyorah force-pushed the st7565r branch from bc78471 to 58762f9 Compare October 11, 2025 14:41

giyorah closed this Oct 11, 2025

JarmouniA reopened this Oct 11, 2025

giyorah closed this Oct 11, 2025

giyorah deleted the st7565r branch October 11, 2025 18:45

This comment was marked as outdated.

Sign in to view

		/* Specify timeout as an absolute time since system boot */
		k_sleep(K_TIMEOUT_ABS_MS(config->ready_time_ms));


		#define DT_DRV_COMPAT sitronix_st7565r

		#if DT_NUM_INST_STATUS_OKAY(DT_DRV_COMPAT) == 0

	title: Sitronix ST7565R dot matrix LCD controller (SPI)
	title: ST7565R LCD controller (SPI)

drivers: display: Introduce ST7565R #91320

drivers: display: Introduce ST7565R #91320

Uh oh!

Conversation

giyorah commented Jun 9, 2025

Uh oh!

JarmouniA left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

faxe1008 Jun 9, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

faxe1008 Jun 9, 2025

Choose a reason for hiding this comment

Uh oh!

giyorah Jun 10, 2025

Choose a reason for hiding this comment

Uh oh!

henrikbrixandersen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sonarqubecloud bot commented Jun 13, 2025

Quality Gate passed

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

giyorah commented Jul 28, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI Jul 31, 2025

Choose a reason for hiding this comment

Uh oh!

giyorah Jul 31, 2025

Choose a reason for hiding this comment

Uh oh!

giyorah commented Oct 8, 2025

Uh oh!

henrikbrixandersen commented Oct 8, 2025

Uh oh!

kartben commented Oct 8, 2025

Uh oh!

giyorah commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kartben commented Oct 9, 2025

Uh oh!

kartben commented Oct 9, 2025

Uh oh!

JarmouniA Oct 11, 2025

Choose a reason for hiding this comment

Uh oh!

JarmouniA Oct 11, 2025

Choose a reason for hiding this comment

Uh oh!

JarmouniA Oct 11, 2025

Choose a reason for hiding this comment

Uh oh!

JarmouniA Oct 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

giyorah commented Oct 9, 2025 •

edited

Loading

JarmouniA Oct 11, 2025 •

edited

Loading