[Backport v4.1-branch] Fix immediate TCP connect failure with loopback and ACD enabled #91469
+16
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When adding IPv4 address to the network interface, there is no need to start ACD procedure for localhost or point-to-point links. The ACD start function would mark the IP address like 127.0.0.1 as tentative and never make it preferred which would then cause issues when selecting the network address for sending. As the ACD start is also called when the network interface comes up, add the localhost and point-to-point link check to ACD start function so that we will avoid ACD checks in this case. Signed-off-by: Jukka Rissanen <[email protected]> (cherry picked from commit 902c95a)
When the network interface goes down, we call net_ipv4_autoconf_reset() which removes the autoaddress from the network interface. The net_ipv4_autoconf_reset() is also called when ACD is started in which case we could see this error message <dbg> net_if_start_acd: Starting ACD for iface 2 <err> net_if: iface 2 addr 169.254.174.230 (net_if_ipv4_addr_rm():4625) <dbg> net_if_ipv4_addr_rm: Address 169.254.174.230 not found (-22) This error is superfluous and not needed. So before trying to remove the address, check if the interface already has it set and only then remove it. Signed-off-by: Jukka Rissanen <[email protected]> (cherry picked from commit bd4c0b7)
|
jukkar
approved these changes
Jun 12, 2025
rlubos
approved these changes
Jun 12, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport bd4c0b7~2..bd4c0b7 from #91294
Fixes #91118.