Skip to content

Conversation

cx-anuj-pathak
Copy link
Contributor

@cx-anuj-pathak cx-anuj-pathak commented Jun 12, 2025

Description

Adds I2S driver for MAX32655 MCU. It was only tested on MAX32655FTHR board using samples/i2s/echo sample.
Theoretically it should work on most MAS32 MCU (except MAX32650/MAX32660 which uses SPIMSS peripheral), given same MXC_I2S_* APIs and config structure are used internally. But due to lack of hardware it is not tested and dts of other mcu/board is also not updated.

Testing

  • checkout to branch and west update
  • build using west build -b max32655fthr/max32655/m4 ..\zephyr\samples\drivers\i2s\echo\
  • flash using openocd.exe -f interface/cmsis-dap.cfg -f target/max32655.cfg -c "init" -c "reset" -c "halt" -c "flash write_image erase build/zephyr/zephyr.hex" -c "reset" -c "exit" (note: use openocd from msdk)
  • speaking into max32655fthr will be echoed to the speaker through the jack.

@cx-anuj-pathak cx-anuj-pathak added the DNM This PR should not be merged (Do Not Merge) label Jun 12, 2025
Copy link

github-actions bot commented Jun 12, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@github-actions github-actions bot added manifest manifest-hal_adi DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Jun 12, 2025
@cx-anuj-pathak cx-anuj-pathak force-pushed the feature-adi-max32-i2s-driver-tx-rx branch 3 times, most recently from 207f3d9 to bc5c1ad Compare June 12, 2025 14:20
@ubieda
Copy link
Member

ubieda commented Jun 12, 2025

@cx-anuj-pathak Please add PR description and Testing evidence

@cx-anuj-pathak cx-anuj-pathak force-pushed the feature-adi-max32-i2s-driver-tx-rx branch 2 times, most recently from 05bd9c5 to c7cdd6f Compare June 13, 2025 10:31
Copy link

@bricle
Copy link
Contributor

bricle commented Aug 11, 2025

@cx-anuj-pathak Thanks for your excellent work, any plans to move this forward? thanks.

@cx-anuj-pathak
Copy link
Contributor Author

cx-anuj-pathak commented Aug 11, 2025

@cx-anuj-pathak Thanks for your excellent work, any plans to move this forward? thanks.

@bricle Yes, I'm active and will iterate over it as soon as dependencies in adi_hal projects are merged. I guess it got paused due to 4.2 release, and hopeful it will resume soon.

Right it forces custom branch in manifest, and causes PR Metadata check fail. That can only be resolved once adi_hal PRs are merged.

@bricle
Copy link
Contributor

bricle commented Aug 11, 2025

@cx-anuj-pathak Thanks for your excellent work, any plans to move this forward? thanks.

@bricle Yes, I'm active and will iterate over it as soon as dependencies in adi_hal projects are merged. I guess it got paused due to 4.2 release, and hopeful it will resume soon.

Right it forces custom branch in manifest, and causes PR Metadata check fail. That can only be resolved once adi_hal PRs are merged.

Very glad to hear this! But it seems no one have noticed these two PRs, maybe you could try to directly ping some regular reviewers from ADI to come into the spotlight. Thanks again for your reply.

@MaureenHelm
Copy link
Member

@cx-anuj-pathak Thanks for your excellent work, any plans to move this forward? thanks.

@bricle Yes, I'm active and will iterate over it as soon as dependencies in adi_hal projects are merged. I guess it got paused due to 4.2 release, and hopeful it will resume soon.
Right it forces custom branch in manifest, and causes PR Metadata check fail. That can only be resolved once adi_hal PRs are merged.

Very glad to hear this! But it seems no one have noticed these two PRs, maybe you could try to directly ping some regular reviewers from ADI to come into the spotlight. Thanks again for your reply.

Thanks for the PR. The adi_hal module is a downstream fork of https://github.com/analogdevicesinc/msdk. Could you please send the hal changes upstream?

@cx-anuj-pathak
Copy link
Contributor Author

@cx-anuj-pathak Thanks for your excellent work, any plans to move this forward? thanks.

@bricle Yes, I'm active and will iterate over it as soon as dependencies in adi_hal projects are merged. I guess it got paused due to 4.2 release, and hopeful it will resume soon.
Right it forces custom branch in manifest, and causes PR Metadata check fail. That can only be resolved once adi_hal PRs are merged.

Very glad to hear this! But it seems no one have noticed these two PRs, maybe you could try to directly ping some regular reviewers from ADI to come into the spotlight. Thanks again for your reply.

Thanks for the PR. The adi_hal module is a downstream fork of https://github.com/analogdevicesinc/msdk. Could you please send the hal changes upstream?

Filed PRs pointing to msdk repo at
analogdevicesinc/msdk#1425
analogdevicesinc/msdk#1426

let me know further coarse of actions

@cx-anuj-pathak
Copy link
Contributor Author

cx-anuj-pathak commented Sep 4, 2025

@MaureenHelm PR to msdk are merged, let me know further course of actions

@leiche-cid
Copy link

@MaureenHelm @ubieda @ozersa Hi, very thanks for your efforts! Politely asking, any plans to move this forward?

@ubieda
Copy link
Member

ubieda commented Sep 12, 2025

I believe this is blocked by #85205

@ttmut
Copy link
Contributor

ttmut commented Oct 10, 2025

Filed PRs pointing to msdk repo at analogdevicesinc/msdk#1425 analogdevicesinc/msdk#1426

let me know further coarse of actions

These two PRs are already part of upstream MSDK and also included in the current hal_adi revision. So, I assume this can move forward.

@cx-anuj-pathak cx-anuj-pathak force-pushed the feature-adi-max32-i2s-driver-tx-rx branch from c7cdd6f to 3e8d13b Compare October 13, 2025 09:28
@github-actions github-actions bot removed manifest manifest-hal_adi DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Oct 13, 2025
@cx-anuj-pathak cx-anuj-pathak force-pushed the feature-adi-max32-i2s-driver-tx-rx branch 2 times, most recently from d349aa0 to bb4c712 Compare October 13, 2025 11:52
- add basic dma only i2s dts binding for max32-i2s
- add i2s node with default config to max32655.dtsi
- add i2s pin definition for max32655fthr board as per spec

Signed-off-by: Anuj Pathak <[email protected]>
@cx-anuj-pathak cx-anuj-pathak force-pushed the feature-adi-max32-i2s-driver-tx-rx branch from bb4c712 to fa9ec11 Compare October 13, 2025 11:56
add necessary build files and i2s driver with tx/rx support

Signed-off-by: Anuj Pathak <[email protected]>
MAX32655 uses I2C1 to control on board PMIC and Audio Codec
this commit enable it as per board spec

Signed-off-by: Anuj Pathak <[email protected]>
Add MAX9867 codec initialization support to the sample
to later use for MAX32655FTHR support

Signed-off-by: Anuj Pathak <[email protected]>
- reduced block length from 100ms to 33.33ms to compile for low ram
- add compile time conditional option to slave mode
- add overlay file for max32655fthr

Signed-off-by: Anuj Pathak <[email protected]>
@cx-anuj-pathak cx-anuj-pathak force-pushed the feature-adi-max32-i2s-driver-tx-rx branch from fa9ec11 to 76b5fc9 Compare October 14, 2025 09:01
@cx-anuj-pathak cx-anuj-pathak removed the DNM This PR should not be merged (Do Not Merge) label Oct 14, 2025
Copy link

@cx-anuj-pathak cx-anuj-pathak marked this pull request as ready for review October 14, 2025 10:41
@cx-anuj-pathak
Copy link
Contributor Author

@MaureenHelm @ttmut @ubieda PR is now ready for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants