Bluetooth: BAP: BA: Refactor discover to not do read #91587
+115
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: Bluetooth
Release Notes
github-actions
bot
requested review from
Casper-Bonde-Bose,
MariuszSkamra,
asbjornsabo,
babrsn,
danieldegrasse,
dkalowsk,
fredrikdanebjer,
jhedberg,
jthm-ot,
kartben,
larsgk,
niym-ot,
pin-zephyr and
sjanc
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Thalley
force-pushed
the
bap_broadcast_assistant_discov_refact
branch
from
953bea5 to
ec091ef
Compare
Thalley
force-pushed
the
bap_broadcast_assistant_discov_refact
branch
from
ec091ef to
34ffd28
Compare
|
@Thalley can you update this to target 4.3 migration guide? |
Thalley
force-pushed
the
bap_broadcast_assistant_discov_refact
branch
from
34ffd28 to
d3a7ba6
Compare
|
Should the bap_broadcast_assistant sample also be updated? |
Thalley
force-pushed
the
bap_broadcast_assistant_discov_refact
branch
from
d3a7ba6 to
daa2496
Compare
Updated the sample |
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors the Bluetooth BAP Broadcast Assistant discover function to simplify its behavior by removing automatic receive state reads at the end of discovery. This breaking change requires users to manually read receive states using the existing API if needed.
- Simplified
bt_bap_broadcast_assistant_discoverto only perform discovery without automatic receive state reads - Removed complex read callback logic that handled both discovery and receive state operations
- Updated sample application to manually read receive states after discovery completion
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| subsys/bluetooth/audio/bap_broadcast_assistant.c | Refactored discover function and simplified read callback by removing automatic receive state reads |
| samples/bluetooth/bap_broadcast_assistant/src/main.c | Added manual receive state reading after discovery to maintain functionality |
| doc/releases/migration-guide-4.3.rst | Documented the breaking change for users |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
larsgk
previously approved these changes
Aug 19, 2025
Thalley
force-pushed
the
bap_broadcast_assistant_discov_refact
branch
from
8cf296d to
03db072
Compare
|
Rebased to solve merge conflicts |
Thalley
force-pushed
the
bap_broadcast_assistant_discov_refact
branch
2 times, most recently
from
b8d2459 to
59ddb60
Compare
Thalley
force-pushed
the
bap_broadcast_assistant_discov_refact
branch
3 times, most recently
from
272229b to
572875b
Compare
|
The failing test passes locally. I've tried a few different offsets and random seeds, but can't really find something that passes locally and in CI :( |
Thalley
force-pushed
the
bap_broadcast_assistant_discov_refact
branch
from
572875b to
8f353cb
Compare
Thalley
force-pushed
the
bap_broadcast_assistant_discov_refact
branch
from
8f353cb to
71f1041
Compare
Thalley
force-pushed
the
bap_broadcast_assistant_discov_refact
branch
from
71f1041 to
074a719
Compare
zephyrbot
added
the
area: Tests
Refactor the bt_bap_broadcast_assistant_discover function to not read receives at the end of discovery. This makes the function more true to what it is supposed to do, and significantly reduces the complexity of the procedure and the read callback. Users will be required to, if wanted, to read the receive state themselves with the existing bt_bap_broadcast_assistant_read_recv_state. The start_offset had to be modified to avoid issues with PA sync. Signed-off-by: Emil Gydesen <[email protected]>
Once the BASS has been discovered, the sample will now attempt to read all the receive states on the remote device. The receive states will only be logged, and the sample will not (yet) perform any logic on them (to e.g. determiner whether it needs to perform a remove source operation before the add source, or perform a modify source). That behavior is postponed to a future commit, as the purpose of this is to showcase reading the receive states. Signed-off-by: Emil Gydesen <[email protected]>
Modify and add some printk statements for the tests, as some were missing the newline. Signed-off-by: Emil Gydesen <[email protected]>
When using PAST, it is best not to use an ACL that is a multiple of the PA or ISO interval to avoid overlaps. Signed-off-by: Emil Gydesen <[email protected]>
Thalley
force-pushed
the
bap_broadcast_assistant_discov_refact
branch
from
074a719 to
cbd41a5
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the bt_bap_broadcast_assistant_discover function to not read receives at the end of discovery.
This makes the function more true to what it is supposed to do, and significantly reduces the complexity of the procedure and the read callback.
Users will be required to, if wanted, to read the
receive state themselves with the existing
bt_bap_broadcast_assistant_read_recv_state.