drivers: sensor: microchip: mtch9010 Added MTCH9010 Device Support #91812

robertperkel · 2025-06-18T07:59:14Z

Added new driver for MTCH9010 liquid leak detector along with test patterns.

robertperkel · 2025-06-18T08:00:22Z

If possible, could we add this for v4.2

drivers/sensor/microchip/mtch9010/mtch9010.c

kartben · 2025-06-18T09:00:32Z

drivers/sensor/microchip/mtch9010/mtch9010.c

+			gpio_pin_set_dt(&config->enableUARTLine, GPIO_OUTPUT_LOW);
+		} else {
+			gpio_pin_set_dt(&config->enableUARTLine, GPIO_OUTPUT_HIGH);


copy-paste error from previous block

Ah, I see. UART EN is active LOW. Clarified intention in comments

no the issue is basically the same thing @msalau commented on. You want to be controlling enableCFGLine here, not enableUARTLine??

Thanks - I think I see the issue now

drivers/sensor/microchip/mtch9010/mtch9010.c

drivers/sensor/microchip/mtch9010/Kconfig

drivers/sensor/microchip/mtch9010/mtch9010.c

tests/drivers/sensor/mtch9010/test_configs/data_format/current.overlay

tests/drivers/sensor/mtch9010/boards/native_sim.overlay

drivers/sensor/microchip/CMakeLists.txt

robertperkel · 2025-06-19T04:16:12Z

@kartben I'm looking at the twister failures, and it doesn't seem related to my PR, as I don't utilize with the file system. Can you confirm or rerun/ignore that twister error?

kartben · 2025-06-19T07:46:39Z

@kartben I'm looking at the twister failures, and it doesn't seem related to my PR, as I don't utilize with the file system. Can you confirm or rerun/ignore that twister error?

yep, had nothing to do with you, and fixed now :)

drivers/sensor/microchip/mtch9010/Kconfig

msalau · 2025-06-19T08:43:06Z

drivers/sensor/microchip/mtch9010/mtch9010.c

+	data->last_heartbeat = k_uptime_get();
+
+	/* Wait for boot-up */
+	k_msleep(CONFIG_MTCH9010_BOOT_TIME_MS);


Just highlighting that this will delay boot up process for all.

Unfortunately, things stop working when I remove this delay. I have some theories, but for now, I'd like to keep this.

msalau · 2025-06-19T08:48:08Z

drivers/sensor/microchip/mtch9010/mtch9010.c

+		LOG_INST_DBG(config->log, "UART setup not enabled");
+
+#ifdef CONFIG_MTCH9010_LOCK_ON_STARTUP
+		BUILD_ASSERT(true, "MTCH9010_LOCK_ON_STARTUP cannot be set without UART enabled");


Location of this BUILD_ASSERT() is somewhat strange to me. It is not a part of the initialization routine. I think it should be closer to MTCH9010_DEFINE() and be checked at build time.

Moved assertion to define section 👍

Please do not resolve comments. This is for the reviewers to do

https://docs.zephyrproject.org/latest/contribute/contributor_expectations.html#workflow-suggestions-that-help-reviewers

My bad - thanks for letting me know

The BUILD_ASSERT keeps causing issues, and since this is an optional feature anyway, I've removed the BUILD_ASSERT.

drivers/sensor/microchip/mtch9010/mtch9010.c

robertperkel · 2025-06-19T20:02:12Z

Looks like everything is good to go on our side 👍 Local test bench is functioning as expected

robertperkel · 2025-06-23T02:31:03Z

Hi @msalau @kartben ,
Since the feature freeze date for v4.2 is this Friday, could you let me know any remaining changes and/or approve the PR?

Additionally - do I need to notify anyone of this for v4.2, or is it automatic?

Thanks for your feedback!
Robert

kartben · 2025-06-23T08:00:22Z

Hi @msalau @kartben , Since the feature freeze date for v4.2 is this Friday, could you let me know any remaining changes and/or approve the PR?

Additionally - do I need to notify anyone of this for v4.2, or is it automatic?

Thanks for your feedback! Robert

I am marking it as tentative for 4.2 but my guess is that it will be tight as it is quite a significant PR and it will take time for reviewers to go through it. Thanks!

JarmouniA · 2025-08-20T15:25:19Z

Sonar Qube issue needs attention
https://sonarcloud.io/project/issues?sinceLeakPeriod=true&issueStatuses=OPEN%2CCONFIRMED&pullRequest=91812&id=zephyrproject-rtos_zephyr&open=AZhIWhdx99fIPT0PFtnv

In general, you should not be validating the value of DT properties that have enum/range in binding, bcz it's done during DT parsing.

sonarqubecloud · 2025-08-20T20:41:40Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

robertperkel · 2025-08-20T20:43:24Z

SonarQube now passing

robertperkel · 2025-09-04T15:47:29Z

@msalau @kartben @MaureenHelm

All of the requested changes have been made - can you review and approve, so we can close this PR?

robertperkel · 2025-10-10T15:15:03Z

@msalau @kartben @MaureenHelm Can you re-review the PR for 4.3?

robertperkel · 2025-10-17T16:49:43Z

Do I need to do anything else for it to be merged, or is it automatic?

kartben · 2025-10-17T16:52:20Z

Do I need to do anything else for it to be merged, or is it automatic?

You're all set. It will be merged shortly :)

kartben · 2025-10-17T16:53:20Z

I am triggering a fresh CI run since the last one was pretty old, just in case

robertperkel · 2025-10-17T17:17:17Z

Looks like Twister build prep is failing - I don't think that's on my side?

kartben · 2025-10-17T17:41:29Z

Looks like Twister build prep is failing - I don't think that's on my side?

ah :| you actually need to rebase on main, please. It won't dismiss your existing approvals :)

Added support for MTCH9010 and applied edits from reviewers. Signed-off-by: Robert Perkel <[email protected]>

Added testsuite to verify MTCH9010 sensor driver Signed-off-by: Robert Perkel <[email protected]>

sonarqubecloud · 2025-10-17T18:25:32Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions bot added the area: Sensors Sensors label Jun 18, 2025

github-actions bot requested review from MaureenHelm, asemjonovs, avisconti, jeppenodgaard, teburd, tristan-google, ubieda and yperess June 18, 2025 08:00

github-actions bot assigned MaureenHelm Jun 18, 2025

kartben requested changes Jun 18, 2025

View reviewed changes

msalau reviewed Jun 18, 2025

View reviewed changes

tests/drivers/sensor/mtch9010/test_configs/data_format/current.overlay Outdated Show resolved Hide resolved

tests/drivers/sensor/mtch9010/boards/native_sim.overlay Show resolved Hide resolved

drivers/sensor/microchip/CMakeLists.txt Outdated Show resolved Hide resolved

robertperkel force-pushed the add_mtch9010_rel_v1 branch 3 times, most recently from cf24bb0 to e4ac4a3 Compare June 19, 2025 04:08

robertperkel requested a review from kartben June 19, 2025 04:15

robertperkel requested a review from msalau June 19, 2025 04:16

msalau reviewed Jun 19, 2025

View reviewed changes

robertperkel force-pushed the add_mtch9010_rel_v1 branch 3 times, most recently from 511c14e to 3b46797 Compare June 19, 2025 19:17

robertperkel requested a review from msalau June 19, 2025 19:50

kartben added this to the v4.2.0 milestone Jun 23, 2025

robertperkel force-pushed the add_mtch9010_rel_v1 branch 5 times, most recently from 1386716 to b73a750 Compare August 20, 2025 20:15

robertperkel requested a review from JarmouniA September 16, 2025 16:03

MaureenHelm approved these changes Oct 17, 2025

View reviewed changes

JarmouniA approved these changes Oct 17, 2025

View reviewed changes

kartben closed this Oct 17, 2025

kartben reopened this Oct 17, 2025

zephyrbot added area: Boards/SoCs area: Tests Issues related to a particular existing or missing test area: Devicetree Bindings labels Oct 17, 2025

zephyrbot requested a review from nashif October 17, 2025 16:54

robertperkel added 2 commits October 17, 2025 11:05

drivers: sensor: microchip: mtch9010 Added mtch9010 support

0af8e8f

Added support for MTCH9010 and applied edits from reviewers. Signed-off-by: Robert Perkel <[email protected]>

tests: drivers: sensor: Added MTCH9010 Tests

e5fd633

Added testsuite to verify MTCH9010 sensor driver Signed-off-by: Robert Perkel <[email protected]>

robertperkel force-pushed the add_mtch9010_rel_v1 branch from b73a750 to e5fd633 Compare October 17, 2025 18:05

cfriedt merged commit 228f0a4 into zephyrproject-rtos:main Oct 18, 2025
26 checks passed

robertperkel deleted the add_mtch9010_rel_v1 branch October 18, 2025 01:10

drivers: sensor: microchip: mtch9010 Added MTCH9010 Device Support #91812

drivers: sensor: microchip: mtch9010 Added MTCH9010 Device Support #91812

Conversation

robertperkel commented Jun 18, 2025

Uh oh!

robertperkel commented Jun 18, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

robertperkel Jun 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

robertperkel commented Jun 19, 2025

Uh oh!

kartben commented Jun 19, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

robertperkel commented Jun 19, 2025

Uh oh!

robertperkel commented Jun 23, 2025

Uh oh!

kartben commented Jun 23, 2025

Uh oh!

JarmouniA commented Aug 20, 2025

Uh oh!

sonarqubecloud bot commented Aug 20, 2025

Quality Gate passed

Uh oh!

robertperkel commented Aug 20, 2025

Uh oh!

robertperkel commented Sep 4, 2025

Uh oh!

robertperkel commented Oct 10, 2025

robertperkel Jun 18, 2025 •

edited

Loading