soc: dts: drivers: add SoCs for amebad series #91933
Conversation
github-actions
bot
added
area: UART
github-actions
bot
requested review from
JasonLin-RealTek,
MaureenHelm,
dcpleung,
gmarull,
henrikbrixandersen,
mnkp,
nashif and
stephanosio
|
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 added project Note: This message is automatically posted and updated by the Manifest GitHub Action. |
github-actions
bot
added
manifest
manifest-hal_realtek
DNM (manifest)
| # This option for code in modules/hal | ||
| config AMEBAD | ||
| bool | ||
| default y |
There was a problem hiding this comment.
it should check SOC_AMEBAD
There was a problem hiding this comment.
I think if SOC_AMEBAD in line 4 has already checked SOC_AMEBAD.
There was a problem hiding this comment.
as in, whole symbol to go, your other code checking for this symbol needs to check for SOC_AMEBAD instead
There was a problem hiding this comment.
Both "config AMEBAD" and "config ARM_CORE_CM4" are required by external modules, and I have already moved them into the Kconfig of the external module.
soc/realtek/ameba/amebad/Kconfig.soc
Outdated
| config ARM_CORE_CM4 | ||
| bool | ||
| default y if SOC_AMEBAD |
There was a problem hiding this comment.
It will be used by the code of external modules. Should I move this definition to the hal_realtek repository?
There was a problem hiding this comment.
this is such a general Kconfig that it's possible it will clash and not only that doesn't even make sense given that it's selecting the m33 symbol then pretending to be an m4
There was a problem hiding this comment.
Both "config AMEBAD" and "config ARM_CORE_CM4" are required by external modules, and I have already moved them into the Kconfig of the external module.
zjian-zhang
force-pushed
the
rtl8721d
branch
2 times, most recently
from
44892fc to
92a9529
Compare
|
zjian-zhang
force-pushed
the
rtl8721d
branch
2 times, most recently
from
764f97d to
4a03fce
Compare
|
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
|
remove stale label |
zjian-zhang
force-pushed
the
rtl8721d
branch
4 times, most recently
from
d29ae34 to
01e4e74
Compare
Realtek HAL (Hardware Abstraction Layer) provides a low level peripheral configuration function. Signed-off-by: zjian zhang <[email protected]>
add initial version of devicetree for amebad SOC. amebad devicetree file is main platform dtsi file, which should be included from board dts (e.g rtl872xd_evb.dts) Signed-off-by: zjian zhang <[email protected]>
Add initial version of Amebad Soc integration Signed-off-by: zjian zhang <[email protected]>
add amebad pin controller driver Signed-off-by: zjian zhang <[email protected]>
loguart driver for amebad Signed-off-by: zjian zhang <[email protected]>
GPIO driver for amebad Signed-off-by: zjian zhang <[email protected]>
add initial version of rtl872xd_evb board Signed-off-by: zjian zhang <[email protected]>
This commit adds maintainers for hal_realtek repository Signed-off-by: zjian zhang <[email protected]>
|
4 participants
The amebad microcontroller (MCU) is an advanced system-on-chip (SoC) featuring an Arm® Cortex®-M33 and Cortex®-M23, large Flash and SRAM memories, and supports dual-band Wi-Fi 4(2.4GHz + 5GHz) and BLE5.0 specifications.
The initial support for the board includes GPIO, PINCTRL and Loguart(serial).