soc: stm32: move stack size definitions to the correct place #92825
Conversation
github-actions
bot
requested review from
FRASTM,
GeorgeCGV,
erwango,
etienne-lms,
gautierg-st,
marwaiehm-st and
mathieuchopstm
|
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
|
@djiatsaf-st @erwango is this intended to ship in 4.3? otherwise, update milestone |
We have 2 weeks, so it remains doable. Up to @djiatsaf-st to confirm. |
I plan to resume this next week |
djiatsaf-st
dismissed stale reviews from FRASTM and mathieuchopstm
via
11935ec
djiatsaf-st
force-pushed
the
handle_stack
branch
2 times, most recently
from
11935ec to
fea885e
Compare
There was a problem hiding this comment.
soc: st: stm32: add common kconfig symbols for kernel stack size should be the first commit.
Also:
add common kconfig symbol for main, idle and isr stack sizes,
Please reword the message: You're not adding the Kconfig symbol, as it exists already, but provide default value depending on ...
djiatsaf-st
force-pushed
the
handle_stack
branch
from
fea885e to
d1260dc
Compare
|
Updated
|
Provide default values for common kconfig symbols for main, idle and isr stack sizes, which apply on all STM32 MCU families with low RAM memory(less than 8 KiB). These kconfig symbols help reduce kernel sizes to fit within limited RAM. Signed-off-by: Fabrice DJIATSA <[email protected]>
These kconfig symbols will be handle in family Kconfig level. Signed-off-by: Fabrice DJIATSA <[email protected]>
These kconfig symbols will be handle in family Kconfig level Signed-off-by: Fabrice DJIATSA <[email protected]>
These kconfig symbols will be handle in family Kconfig Level Signed-off-by: Fabrice DJIATSA <[email protected]>
djiatsaf-st
force-pushed
the
handle_stack
branch
from
d1260dc to
b003155
Compare
|
|
|
||
| config IDLE_STACK_SIZE | ||
| default 100 if SRAM_SIZE <= 2 | ||
| default 150 if SRAM_SIZE <= 4 |
There was a problem hiding this comment.
Despite this change is synced with the value previosly used in applicable SoCs, I find it strange the stack size is not a multiple of a 32bit word size.
This comment is outside the scope of this P-R, not blocking.
There was a problem hiding this comment.
I think Zephyr aligns the size internally.
7 participants
Following discussions in #85368
This PR moves the definitions of
MAIN_STACK_SIZE,IDLE_STACK_SIZE, andISR_STACK_SIZEto a family Kconfig level.These changes specifically concern the STM32 families boards with low RAM memory (less than 8 KiB).