Skip to content

Conversation

asm5878
Copy link
Contributor

@asm5878 asm5878 commented Jul 8, 2025

Aim of this PR is a cleaner support of stop/stdby modes for stm32wbax socs.
System power management has been reworked to remove:

  • the dependency on scm (system clock manager) module.
  • all the assumptions on the BLE hci driver activation

Scope of this PR has been reduced to manage only the pm at system level.
A new PR (#95151) has been created to update the pm for the stm32wbax ble hci driver.

FYI: @Chastillon

@asm5878 asm5878 changed the title PM rework to support STOP/STDBY modes with radio activity STM32WBAX PM rework to support STOP/STDBY modes with radio activity Jul 8, 2025
Copy link

github-actions bot commented Jul 8, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_stm32 zephyrproject-rtos/hal_stm32@465fb02 zephyrproject-rtos/hal_stm32@3a4b521 (main) zephyrproject-rtos/[email protected]

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@github-actions github-actions bot added manifest manifest-hal_stm32 DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Jul 8, 2025
Copy link
Contributor

@msmttchr msmttchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @asm5878, thanks a lot for this draft PR, very interesting proposal. I added few preliminary comments, and I would like also to involve @HoZHel and @FrancescoCiminoST

@asm5878 asm5878 force-pushed the STM32WBAX_PM_Enhancements branch from e119b24 to a58e6c7 Compare August 1, 2025 08:59
@asm5878 asm5878 force-pushed the STM32WBAX_PM_Enhancements branch 3 times, most recently from ac8ec9f to b1e2b46 Compare August 22, 2025 11:16
@asm5878 asm5878 marked this pull request as ready for review August 22, 2025 12:02
@asm5878 asm5878 requested a review from mathieuchopstm August 22, 2025 12:03
@zephyrbot zephyrbot added the area: Samples Samples label Aug 22, 2025
@asm5878 asm5878 requested a review from msmttchr August 22, 2025 12:03
@zephyrbot zephyrbot added the area: Bluetooth HCI Bluetooth HCI Driver label Aug 22, 2025
@asm5878 asm5878 requested a review from MBrandt-Z August 22, 2025 12:03
@zephyrbot zephyrbot added area: Bluetooth Host Bluetooth Host (excluding BR/EDR) area: Bluetooth platform: STM32 ST Micro STM32 labels Aug 22, 2025
@jhedberg jhedberg removed the area: Bluetooth HCI Bluetooth HCI Driver label Aug 28, 2025
Copy link
Contributor

@mathieuchopstm mathieuchopstm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM 🚀

Copy link
Contributor

@msmttchr msmttchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. For some reason I can’t “resolve conversations” (button is not shown for me). If you can, you can mark all my conversations resolved.

Copy link
Contributor

@etienne-lms etienne-lms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments.

@asm5878 asm5878 force-pushed the STM32WBAX_PM_Enhancements branch from 67e08da to 11e0232 Compare September 3, 2025 12:52
mathieuchopstm
mathieuchopstm previously approved these changes Sep 3, 2025
Copy link
Contributor

@etienne-lms etienne-lms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM AFAICT.

etienne-lms
etienne-lms previously approved these changes Sep 3, 2025
Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

west.yml Outdated
- hal
- name: hal_stm32
revision: 611d54c237623ea71a367502bfbd736fc67ba15f
revision: pull/294/head
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3a4b521441607646ec43bece2c53f333ce7f9b69

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @erwango . Done

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflict.... Rebase on going

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased and conflict solved

@asm5878 asm5878 dismissed stale reviews from etienne-lms and mathieuchopstm via 0201e99 September 4, 2025 13:56
@asm5878 asm5878 force-pushed the STM32WBAX_PM_Enhancements branch from 11e0232 to 0201e99 Compare September 4, 2025 13:56
@github-actions github-actions bot removed the DNM (manifest) This PR should not be merged (controlled by action-manifest) label Sep 4, 2025
soc power management rework to support power states
removing dependency on ST system clock manager (SCM).

Signed-off-by: Alessandro Manganaro <[email protected]>
Updating standby exit latency time according worst case value
from stm32wba5 and stm32wba6 datasheets.

Signed-off-by: Alessandro Manganaro <[email protected]>
@asm5878 asm5878 force-pushed the STM32WBAX_PM_Enhancements branch from 0201e99 to b4e6338 Compare September 4, 2025 14:03
Copy link

sonarqubecloud bot commented Sep 4, 2025

Please retry analysis of this Pull-Request directly on SonarQube Cloud

@kartben kartben merged commit a3a27d0 into zephyrproject-rtos:main Sep 4, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants