Power harness: Update path for the raw data file. #93100
Conversation
gbarkadiusz
force-pushed
the
topic/change_path_for_raw_data
branch
2 times, most recently
from
1485502 to
030ee22
Compare
|
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
| output_file: str = "rawData.csv" | ||
| output_file: str = field( | ||
| default_factory=lambda: os.path.join( | ||
| os.environ.get("ZEPHYR_BASE", "."), "twister-out", "power_raw_data.csv" |
There was a problem hiding this comment.
"twister-out" shouldn't be hard-coded as the outdir can be configured.
There was a problem hiding this comment.
I no longer have access to the hardware required for that particular test. Please proceed by either merging it as is or creating a new pull request with the changes you proposed.
There was a problem hiding this comment.
@kartben i will provide changes based on your suggestion
There was a problem hiding this comment.
I have reverted this change, file was overwritten when multiple test runs. Using --build-dir in test_power.py resolves this by producing file per scenario in correct path
majunkier
force-pushed
the
topic/change_path_for_raw_data
branch
from
030ee22 to
8465c2f
Compare
majunkier
force-pushed
the
topic/change_path_for_raw_data
branch
from
8465c2f to
032e43e
Compare
zephyrbot
requested review from
KamilxPaszkiet,
LukaszMrugala,
PerMac,
gchwier,
golowanow and
hakehuang
Change direction for raw data file from $ZEPHYR_BASE to <path_to>twister-out/../<test>/ Signed-off-by: Arkadiusz Cholewinski <[email protected]>
majunkier
force-pushed
the
topic/change_path_for_raw_data
branch
from
032e43e to
45760ad
Compare
|
rebase done |
|
5 participants
Change direction for raw data file from $ZEPHYR_BASE to <path_to>twister-out/..//