Skip to content

soc: mchp: Introduce support to SAMA7D65 #93133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

soc: mchp: Introduce support to SAMA7D65 #93133

wants to merge 7 commits into from

Conversation

TonyHan11
Copy link
Contributor

This pull request introduces the minimal support for Microchip sama7d65-curiosity board.
Tested with samples/hello_world and samples/subsys/shell/shell_module.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 15, 2025 •
edited
Loading

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

nordicjm
nordicjm previously approved these changes Jul 15, 2025
View reviewed changes
@nordicjm nordicjm requested a review from kartben July 15, 2025 06:54
kartben
kartben requested changes Jul 15, 2025
View reviewed changes
@TonyHan11 TonyHan11 requested review from kartben and nordicjm July 16, 2025 03:27
@nandojve nandojve changed the title Add minimal support for Microchip SAMA7D65-curiosity board soc: mchp: Introduce support to SAMA7D65 Jul 16, 2025
nordicjm
nordicjm previously approved these changes Jul 16, 2025
View reviewed changes
kartben
kartben previously approved these changes Jul 16, 2025
View reviewed changes
@albertofloyd albertofloyd removed their request for review August 4, 2025 20:45
@TonyHan11 TonyHan11 dismissed stale reviews from kartben and nordicjm via 099de03 August 13, 2025 02:33
@nandojve nandojve self-requested a review August 13, 2025 05:50
kartben
kartben previously approved these changes Aug 14, 2025
View reviewed changes
@nandojve
Copy link
Member

nandojve commented Sep 6, 2025

Hi @TonyHan11 ,

Reorder the commits.

@zephyrbot zephyrbot added the platform: Microchip SAM Microchip SAM Platform (formerly Atmel SAM) label Sep 8, 2025
@TonyHan11
soc: microchip: sam: optimize name for sama7g5 programmable clock
9a865fd 
Change the location of the names for programable clocks from the
stack to "static struct clk_programmable" array.

Signed-off-by: Tony Han <[email protected]>
@TonyHan11
soc: microchip: sam: optimize array size for sama7g5 registered clocks
5ca6417 
Replace the array size for sama7g5 registered clocks with macros and
put the macros to soc.h with descriptions.

Signed-off-by: Tony Han <[email protected]>
@TonyHan11
Copy link
Contributor Author

Hi @TonyHan11 ,

Reorder the commits.

Commits reordered with:

2 commits of clock optimize (for adding support for sama7d65 later)
soc dtsi
soc code
register soc clock
board dts
board files

@nandojve nandojve assigned nandojve and unassigned nordic-krch Sep 15, 2025
@nandojve nandojve added this to the v4.3.0 milestone Sep 15, 2025
nandojve
nandojve requested changes Sep 15, 2025
View reviewed changes
@TonyHan11
dts: microchip: add the DTSI file for sama7d65
abedc33 
Add the base DTSI file for Microchip sama7d65.

Signed-off-by: Tony Han <[email protected]>
@TonyHan11
soc: microchip: add new soc sama7d65
3697fb2 
Product URL: https://www.microchip.com/en-us/product/SAMA7D65

Signed-off-by: Tony Han <[email protected]>
@TonyHan11
include: dt-bindings: sam_pmc: add PMC clocks for SAMA7D65
b00cf62 
Add LVDSPLL, MCK3 and MCK5 clock definitions for microchip SAMA7D65.

Signed-off-by: Tony Han <[email protected]>
@TonyHan11
soc: microchip: sam: register clocks for sama7d65
5173e51 
Register sama7d65 clocks in sam_pmc_setup() which will be called by
the PMC driver.

Signed-off-by: Tony Han <[email protected]>
@TonyHan11 TonyHan11 requested a review from nandojve September 16, 2025 07:14
nandojve
nandojve requested changes Sep 16, 2025
View reviewed changes
boards/microchip/sam/sama7d65_curiosity/sama7d65_curiosity.yaml
Comment on lines 11 to 15
supported:
- shell
- uart
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All drivers added by the "dts: microchip: add the DTSI file for sama7d65" devicetree commit must be present on this list and pass. Any that fail - no driver available - must be added/enabled later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gic, i2c and pmc added to the support list, thanks.

nandojve
nandojve requested changes Sep 17, 2025
View reviewed changes
boards/microchip/sam/sama7d65_curiosity/sama7d65_curiosity.yaml Outdated
- zephyr
ram: 128
supported:
- gic
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are the gic and pmc sample/tests ?
and
Why pinctrl is not in the list ?

This is how do you know the tags : )

zephyr/tests/drivers/pinctrl/api/testcase.yaml

Line 14 in b8576db

- pinctrl

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'll remove the gic and pmc. pinctrl will be added in the comming updates. Thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the list: gic and pmc removed, pinctrl added.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 9, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
8.4% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nandojve nandojve nandojve requested changes

@kartben kartben kartben left review comments

@nordicjm nordicjm nordicjm left review comments

@jvasanth1 jvasanth1 Awaiting requested review from jvasanth1

@nordic-krch nordic-krch Awaiting requested review from nordic-krch

@VenkatKotakonda VenkatKotakonda Awaiting requested review from VenkatKotakonda

@mnkp mnkp Awaiting requested review from mnkp

@pdgendt pdgendt Awaiting requested review from pdgendt

@stephanosio stephanosio Awaiting requested review from stephanosio

Requested changes must be addressed to merge this pull request.

Assignees

@nandojve nandojve

Labels

area: Boards/SoCs area: Clock Control area: Devicetree Bindings platform: Microchip MEC Microchip MEC Platform platform: Microchip SAM Microchip SAM Platform (formerly Atmel SAM)

Projects

None yet

Milestone

v4.3.0

Development

Successfully merging this pull request may close these issues.

6 participants

@TonyHan11 @nandojve @kartben @nordicjm @nordic-krch @zephyrbot