drivers: STM32 async flash erase and write #93173

jpowen898 · 2025-07-16T05:25:09Z

Implemented async flash erase and writes using the STM32 hal HAL_FLASHEx_Erase_IT() and HAL_FLASH_Program_IT() functions with their associated interrupt handler.
I only implemented this for the h7, l4, and f4 stm32 families because that is the hardware I had available to test on.
Async flash transactions can be enabled using the FLASH_STM32_ASYNC config option.
Async transactions are implemented using a semaphore which blocks while waiting for the flash IRQ to indicate the end of a flash transaction. This allows other threads to take action while flash erase and write actions are taking place.

github-actions · 2025-07-16T05:25:48Z

Hello @jpowen898, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

drivers/flash/Kconfig

drivers/flash/flash_stm32.c

drivers/flash/flash_stm32f4x.c

jpowen898 · 2025-07-16T14:51:56Z

@nordicjm Thanks for the feedback. I made all the requested changes, let me know if there is anything else.

Addressed

drivers/flash/Kconfig.stm32

jpowen898 · 2025-07-25T21:38:43Z

I just did some testing with this on the stm32h743 and it is failing to erase the correct sectors because of this issue #93714 where the flash size is being calculated incorrectly (4MB when it should be 2MB) and caused the get_sector() to return the wrong bank and sector numbers. It looks like there is a PR open to fix it already #93739.

drivers/flash/flash_stm32f4x.c

drivers/flash/flash_stm32h7x.c

drivers/flash/flash_stm32l4x.c

drivers/flash/flash_stm32h7x.c

drivers/flash/flash_stm32f4x.c

drivers/flash/flash_stm32.c

drivers/flash/flash_stm32f4x.c

etienne-lms

Check also the few comments posted by CI compliance checks bot.

drivers/flash/flash_stm32.c

drivers/flash/flash_stm32f4x.c

Added optional use of the stm32 hal async flash write and erase capabilities on the l4, f4, and h7 soc families. It is implemented using semaphores to allow for other threads to take action during the erase/write actions. This feature is disabled by default and can be optionally enabled using the FLASH_STM32_ASYNC config option. Signed-off-by: Parker Owen <[email protected]>

sonarqubecloud · 2025-09-05T15:31:34Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
20.3% Duplication on New Code

See analysis details on SonarQube Cloud

etienne-lms

Minor issues, otherwise LGTM.

etienne-lms · 2025-09-16T07:42:03Z

drivers/flash/flash_stm32l4x.c

+#else /* CONFIG_FLASH_STM32_ASYNC */
+
+	int rc;
+	uint32_t tmp;


tmp is already defined at function entry.

etienne-lms · 2025-09-16T07:44:13Z

drivers/flash/flash_stm32l4x.c

 #endif /* CONTROL_DCACHE */

 	return rc;
+#endif /* !CONFIG_FLASH_STM32_ASYNC */


Prefer:

Suggested change

#endif /* !CONFIG_FLASH_STM32_ASYNC */

#endif /* CONFIG_FLASH_STM32_ASYNC */

Ditto at a few other places.

github-actions bot added area: Flash platform: STM32 ST Micro STM32 labels Jul 16, 2025

github-actions bot requested a review from erwango July 16, 2025 05:26

github-actions bot assigned de-nordic Jul 16, 2025

nordicjm previously requested changes Jul 16, 2025

View reviewed changes

jpowen898 force-pushed the main branch 2 times, most recently from c34e153 to ae67109 Compare July 16, 2025 14:49

jpowen898 force-pushed the main branch 3 times, most recently from 030ad53 to df9a4f8 Compare July 16, 2025 17:38

jpowen898 requested a review from nordicjm July 16, 2025 17:56

jpowen898 force-pushed the main branch from df9a4f8 to 9b4eca5 Compare July 16, 2025 18:25

zephyrbot requested review from FRASTM, GeorgeCGV, de-nordic, djiatsaf-st, gautierg-st, marwaiehm-st, mathieuchopstm and rghaddab July 17, 2025 02:52

nordicjm reviewed Jul 17, 2025

View reviewed changes

drivers/flash/Kconfig.stm32 Outdated Show resolved Hide resolved

nordicjm reviewed Jul 17, 2025

View reviewed changes

drivers/flash/Kconfig.stm32 Outdated Show resolved Hide resolved

jpowen898 force-pushed the main branch from 9b4eca5 to 3269120 Compare July 17, 2025 16:04

zephyrbot requested a review from etienne-lms July 17, 2025 16:05

jpowen898 force-pushed the main branch 2 times, most recently from 9129568 to b5d3812 Compare July 17, 2025 16:13

jpowen898 requested a review from nordicjm July 17, 2025 16:16

jpowen898 force-pushed the main branch from dbdff2d to 42d05a2 Compare July 25, 2025 14:32

jpowen898 requested a review from erwango July 25, 2025 14:36

jpowen898 force-pushed the main branch from 42d05a2 to 0c0ad0b Compare July 28, 2025 17:31

zephyrbot added the Release Notes To be mentioned in the release notes label Jul 28, 2025

zephyrbot requested review from cfriedt and jhedberg July 28, 2025 17:31

jpowen898 force-pushed the main branch 3 times, most recently from caed1f4 to 7157818 Compare July 31, 2025 15:11

jpowen898 force-pushed the main branch from 7157818 to e11b251 Compare August 8, 2025 17:09

etienne-lms reviewed Aug 11, 2025

View reviewed changes

jpowen898 force-pushed the main branch 3 times, most recently from 2fcb9cc to 5f8a446 Compare August 26, 2025 23:02

jpowen898 requested a review from etienne-lms August 26, 2025 23:02

jpowen898 force-pushed the main branch from 5f8a446 to ce9d361 Compare September 2, 2025 17:15

etienne-lms reviewed Sep 3, 2025

View reviewed changes

jpowen898 requested a review from etienne-lms September 3, 2025 18:29

jpowen898 force-pushed the main branch from ce9d361 to 2307fef Compare September 3, 2025 18:29

etienne-lms reviewed Sep 4, 2025

View reviewed changes

jpowen898 force-pushed the main branch 2 times, most recently from 3a8c216 to d018bc6 Compare September 4, 2025 19:55

jpowen898 requested a review from etienne-lms September 4, 2025 19:58

jpowen898 force-pushed the main branch from d018bc6 to 45c789f Compare September 5, 2025 14:29

jpowen898 force-pushed the main branch from 45c789f to 130f46e Compare September 5, 2025 15:05

etienne-lms reviewed Sep 16, 2025

View reviewed changes

JarmouniA approved these changes Sep 16, 2025

View reviewed changes

	#endif /* !CONFIG_FLASH_STM32_ASYNC */
	#endif /* CONFIG_FLASH_STM32_ASYNC */

drivers: STM32 async flash erase and write #93173

Are you sure you want to change the base?

drivers: STM32 async flash erase and write #93173

Conversation

jpowen898 commented Jul 16, 2025

Uh oh!

github-actions bot commented Jul 16, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jpowen898 commented Jul 16, 2025

Uh oh!

Uh oh!

Uh oh!

jpowen898 commented Jul 25, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

etienne-lms left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Sep 5, 2025

Quality Gate passed

Uh oh!

etienne-lms left a comment

Choose a reason for hiding this comment

Uh oh!

etienne-lms Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

etienne-lms Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants