Skip to content

NXP Add SCMI P2A workflow and BBNSM protocol #93305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

NXP Add SCMI P2A workflow and BBNSM protocol #93305

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ee512b4
drivers: firmware: scmi: Add support for SCMI P2A workflow
yongxu-wang15 Jul 18, 2025
749274f
drivers: firmware: scmi: Add RX callbak in mbox
yongxu-wang15 Oct 10, 2025
7ab7a84
drivers: firmware: scmi: add api to clear channel status
yongxu-wang15 Oct 10, 2025
a3233c5
drivers: firmware: scmi: add msg_type validation in callback
yongxu-wang15 Oct 10, 2025
bcba9ec
drivers: firmware: scmi: add event registration and core dispatcher
yongxu-wang15 Oct 13, 2025
8821a9f
drivers: firmware: scmi: add scmi_read_message for notification handling
yongxu-wang15 Oct 13, 2025
bf9d35d
drivers: firmware: scmi: add NXP bbnsm domain protocol
yongxu-wang15 Oct 13, 2025
e0679ec
dts: bindings: scmi: Update shmem from phandle into phandles
yongxu-wang15 Jul 18, 2025
7fb6b89
dts: arm: nxp: nxp_imx95_m7: add scmi rx shmem and bbm node
yongxu-wang15 Oct 13, 2025
d876137
soc: nxp: imx95: enable scmi bbm button notification for m7 core
yongxu-wang15 Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 37 additions & 16 deletions drivers/firmware/scmi/mailbox.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,22 @@

LOG_MODULE_REGISTER(scmi_mbox);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/callbak/callback/ in the commit subject.


static void scmi_mbox_cb(const struct device *mbox,
mbox_channel_id_t channel_id,
void *user_data,
struct mbox_msg *data)
static void scmi_mbox_tx_reply_cb(const struct device *mbox,
mbox_channel_id_t channel_id,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split this into 2 patches:

  1. Preparation for introducing the RX channel. Here you rename scmi_mbox_cb -> scmi_mbox_tx_reply_cb and implement scmi_mbox_cb with the logic for supporting tx/rx direction but only TX implemented so far.
  2. Add the RX channel.

Much easier to review the transition like this.

void *user_data,
struct mbox_msg *data)
{
struct scmi_channel *scmi_chan = user_data;

if (scmi_chan->cb) {
scmi_chan->cb(scmi_chan);
}
}

static void scmi_mbox_notify_cb(const struct device *mbox,
mbox_channel_id_t channel_id,
void *user_data,
struct mbox_msg *data)
{
struct scmi_channel *scmi_chan = user_data;

Expand Down Expand Up @@ -71,25 +83,34 @@ static int scmi_mbox_setup_chan(const struct device *transport,
{
int ret;
struct scmi_mbox_channel *mbox_chan;
struct mbox_dt_spec *tx_reply;
struct mbox_dt_spec *mbox_spec;

mbox_chan = chan->data;

if (mbox_chan->tx_reply.dev) {
tx_reply = &mbox_chan->tx_reply;
if (tx) {
mbox_spec = mbox_chan->tx_reply.dev ? &mbox_chan->tx_reply : &mbox_chan->tx;
ret = mbox_register_callback_dt(mbox_spec, scmi_mbox_tx_reply_cb, chan);
if (ret < 0) {
LOG_ERR("failed to register reply cb on %s",
mbox_chan->tx_reply.dev ? "tx_reply" : "tx");
return ret;
}
} else {
tx_reply = &mbox_chan->tx;
}

ret = mbox_register_callback_dt(tx_reply, scmi_mbox_cb, chan);
if (ret < 0) {
LOG_ERR("failed to register tx reply cb");
return ret;
if (!mbox_chan->rx.dev) {
LOG_ERR("RX channel not defined");
return -ENOTSUP;
}
mbox_spec = &mbox_chan->rx;
ret = mbox_register_callback_dt(&mbox_chan->rx, scmi_mbox_notify_cb, chan);
if (ret < 0) {
LOG_ERR("failed to register notify cb on rx");
return ret;
}
}

ret = mbox_set_enabled_dt(tx_reply, true);
ret = mbox_set_enabled_dt(mbox_spec, true);
if (ret < 0) {
LOG_ERR("failed to enable tx reply dbell");
LOG_ERR("failed to enable %s dbell", tx ? "tx" : "rx");
}

/* enable interrupt-based communication */
Expand Down