Skip to content

[Backport v4.2-branch] samples: rtxxx-amp: Add service_area section #93371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
github-actions wants to merge 1 commit into from
Closed

[Backport v4.2-branch] samples: rtxxx-amp: Add service_area section #93371

github-actions wants to merge 1 commit into from

Conversation

@github-actions
Copy link

@github-actions github-actions bot commented Jul 19, 2025

Backport 2d388ba from #92895.

@VitekST @github-actions
samples: rtxxx-amp: Add service_area section
0f13b59 
Add the service_area section to the list of sections for which objcopy
is executed. As this section was missing from the resulting data image,
it prevents targets (right now, the mimxrt685s/hifi4) from booting.

Signed-off-by: Vit Stanicek <[email protected]>
(cherry picked from commit 2d388ba)
@github-actions github-actions bot added the Backport Backport PR and backport failure issues label Jul 19, 2025
@github-project-automation github-project-automation bot moved this to To do in Backports Jul 19, 2025
@dkalowsk dkalowsk added this to the v4.2.1 milestone Jul 27, 2025
@github-project-automation github-project-automation bot moved this from To do to Done in Backports Jul 28, 2025
@github-project-automation github-project-automation bot moved this from Done to Needs more info in Backports Jul 28, 2025
@zephyrbot zephyrbot added platform: NXP NXP size: XS A PR changing only a single line of code area: Samples Samples labels Jul 28, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 28, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@danieldegrasse
Copy link
Contributor

danieldegrasse commented Jul 29, 2025

@VitekST if you'd like to backport this to 4.2, can you add an issue describing what this change fixes that we can link from this PR?

@VitekST
Copy link
Contributor

VitekST commented Jul 30, 2025 •
edited
Loading

@danieldegrasse Here it is: #93869

But I've just realised that the commit that broke the examples (653f1bf, #90014) was reverted (#93158), so the examples do indeed work. If it'll stay reverted, there's no need to backport this. Apologies for the confusion.

@danieldegrasse
Copy link
Contributor

danieldegrasse commented Jul 30, 2025

@danieldegrasse Here it is: #93869

But I've just realised that the commit that broke the examples (653f1bf, #90014) was reverted (#93158), so the examples do indeed work. If it'll stay reverted, there's no need to backport this. Apologies for the confusion.

No worries- going to go ahead and close this then

@github-project-automation github-project-automation bot moved this from Needs more info to Done in Backports Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkalowsk dkalowsk dkalowsk approved these changes

@mmahadevan108 mmahadevan108 mmahadevan108 approved these changes

@butok butok Awaiting requested review from butok

@decsny decsny Awaiting requested review from decsny

@DerekSnell DerekSnell Awaiting requested review from DerekSnell

@dleach02 dleach02 Awaiting requested review from dleach02

@EmilioCBen EmilioCBen Awaiting requested review from EmilioCBen

@kartben kartben Awaiting requested review from kartben

@nashif nashif Awaiting requested review from nashif

Assignees

@mmahadevan108 mmahadevan108

@dleach02 dleach02

Labels

area: Samples Samples Backport Backport PR and backport failure issues platform: NXP NXP size: XS A PR changing only a single line of code

Projects

Backports
Status: Done

Milestone

v4.2.1

Development

Successfully merging this pull request may close these issues.

7 participants

@danieldegrasse @VitekST @dkalowsk @mmahadevan108 @zephyrbot @dleach02