Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean that you have submitted the changes upstream? (if so please link to that in the TF-M PR commits)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to the Zephyr repository (shown in the revision above). I suppose I should attempt to figure out how to submit upstream to tf-m.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, that looks extremely complicated. Can we get some review here first and see if this change is reasonable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. I can also submit the changes upstream for you if needed.
Though I'm not qualified to review the changes in zephyrproject-rtos/trusted-firmware-m#134. I mentioned the PR to upstream maintainers so I hope they can also chime in to tell their opinions. (cc @Anton-TF @adeaarm)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're willing to shepherd the change upstream, that would be helpful (especially given their email-based submission process).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, the trusted-firmware-m changes are actually passing tests with both Zephyr SDK version 0.17 (+ a few patches) and SDK version 0.18 (alpha4 + a few patches). I think they're ready for review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still find the commit message (
This is queued for merging but not yet upstream.
) a tad confusing, please update it when you make changes to the PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tf-m isn't email based, but uses Gerrit, which admittedly will be kind of foreign to people not using it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the tf-m changes were split out to #94367 and are now passing all tests. I've updated the commit messages in the module to clarify what they do.