Skip to content

drivers: spi: Add NXP SC18IS606 I2C to SPI bridge #93706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 22, 2025
Merged

drivers: spi: Add NXP SC18IS606 I2C to SPI bridge #93706

merged 2 commits into from
Oct 22, 2025

Conversation

@zacck
Copy link
Contributor

@zacck zacck commented Jul 25, 2025 •
edited
Loading

Introduce I2C to SPI bridge driver support for the SC18IS6906 bridge from NXP.

This adds an SPIO controller available on the bridge from NXP. Ideally this enables one to add an SPI Bus master through i2c

@zacck
Copy link
Contributor Author

zacck commented Jul 25, 2025

@josuah @Pancakem can I ask for your eyes please as I set up my emulator does this make sense?

pdgendt
pdgendt requested changes Jul 25, 2025
View reviewed changes
@pdgendt
Copy link
Contributor

pdgendt commented Jul 25, 2025

Squash your commits so there's only two:

  • Introduce the new driver
  • Add testcase

@zacck zacck force-pushed the pr-sc18is606-bridge branch from 2188e56 to 81d2b2b Compare August 1, 2025 07:20
@zacck zacck force-pushed the pr-sc18is606-bridge branch from 60168f8 to a5e687e Compare August 11, 2025 12:04
josuah
josuah reviewed Aug 11, 2025
View reviewed changes
@zacck zacck force-pushed the pr-sc18is606-bridge branch 2 times, most recently from 55a4762 to 3216479 Compare August 15, 2025 09:51
@zacck zacck marked this pull request as ready for review August 15, 2025 09:51
@zacck
Copy link
Contributor Author

zacck commented Aug 15, 2025

@pdgendt I tried to work through all the stuff I think this is ready for merge, unless I missed something

@zephyrbot zephyrbot added platform: NXP Drivers NXP Semiconductors, drivers area: MFD area: SPI SPI bus labels Aug 15, 2025
@zacck zacck force-pushed the pr-sc18is606-bridge branch from 3216479 to 44e48b6 Compare August 15, 2025 10:29
josuah
josuah reviewed Aug 15, 2025
View reviewed changes
Copy link
Contributor

@josuah josuah left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is another review round, I will pursue further but this hopefully allow you to move forward.

Thank you for the changes and the patience!

@zacck zacck force-pushed the pr-sc18is606-bridge branch from 44e48b6 to 937df4a Compare August 15, 2025 11:08
josuah
josuah reviewed Aug 15, 2025
View reviewed changes
seov-nordic
seov-nordic reviewed Aug 15, 2025
View reviewed changes
Copy link
Member

@seov-nordic seov-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few (mostly minor) suggestions. But the return code comment requires attention

josuah
josuah reviewed Aug 15, 2025
View reviewed changes
Copilot
Copilot AI reviewed Sep 13, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@zacck zacck force-pushed the pr-sc18is606-bridge branch 2 times, most recently from 2b049d7 to 1248551 Compare September 15, 2025 06:36
@zacck
Copy link
Contributor Author

zacck commented Sep 15, 2025

@kartben I removed the PM work as I was unsure of some bits, I think this them passes the rest of the stuff. Please re run Copilot if you wish.

@zacck zacck force-pushed the pr-sc18is606-bridge branch from 1248551 to 500a06a Compare September 15, 2025 06:38
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

seov-nordic
seov-nordic previously approved these changes Sep 18, 2025
View reviewed changes
Copy link
Member

@seov-nordic seov-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work! some final bits from me

@zacck
Copy link
Contributor Author

zacck commented Sep 18, 2025

great work! some final bits from me

Oh my I can’t believe, will do the clarity bits

@zacck
Copy link
Contributor Author

zacck commented Oct 15, 2025

@tbursztyka @pdgendt If I could have another pass of reviews please

pdgendt
pdgendt reviewed Oct 16, 2025
View reviewed changes
@zacck
drivers: spi: Introduce SC18IS606 SPI bridge driver
7ac6c4e 
Added the driver implementation and Kconfig choices

Signed-off-by: Zacck Osiemo <[email protected]>
@zacck zacck force-pushed the pr-sc18is606-bridge branch from 500a06a to a7149cc Compare October 16, 2025 16:07
@zephyrbot zephyrbot added area: Boards/SoCs area: Tests Issues related to a particular existing or missing test platform: NXP NXP area: Devicetree Bindings labels Oct 16, 2025
@zephyrbot zephyrbot requested a review from nashif October 16, 2025 16:09
@zacck zacck requested review from pdgendt and seov-nordic October 16, 2025 16:10
@zacck
Copy link
Contributor Author

zacck commented Oct 16, 2025

@pdgendt @seov-nordic Here are the recommendations put in if I may ask for another round of reviews please.

@zacck zacck force-pushed the pr-sc18is606-bridge branch from a7149cc to 3d3b0c6 Compare October 17, 2025 03:38
@zacck
Copy link
Contributor Author

zacck commented Oct 17, 2025

@pdgendt I broke the tests, fixed now could I please ask for another pass please cc @tbursztyka @seov-nordic Thank you all so much for the patience.

@zacck
tests: spi: include correct overlay for sc18is606
28c9990 
Apply correct device tree overlay is applied for SC18IS606

Signed-off-by: Zacck Osiemo <[email protected]>
@zacck zacck force-pushed the pr-sc18is606-bridge branch from 3d3b0c6 to 28c9990 Compare October 17, 2025 04:15
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

pdgendt
pdgendt approved these changes Oct 17, 2025
View reviewed changes
Copy link
Contributor

@pdgendt pdgendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple nits

drivers/spi/spi_sc18is606.c
return ret;
}

if (cfg->reset_gpios.port) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (cfg->reset_gpios.port) {
if (cfg->reset_gpios.port != NULL) {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do in the GPIO PR

drivers/spi/spi_sc18is606.c
}
}

if (cfg->int_gpios.port) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (cfg->int_gpios.port) {
if (cfg->int_gpios.port != NULL) {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do in the GPIO PR

@cfriedt cfriedt merged commit 9a48b1a into zephyrproject-rtos:main Oct 22, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@tbursztyka tbursztyka tbursztyka approved these changes

@pdgendt pdgendt pdgendt approved these changes

@seov-nordic seov-nordic seov-nordic approved these changes

@aasinclair aasinclair Awaiting requested review from aasinclair

@dbaluta dbaluta Awaiting requested review from dbaluta

@decsny decsny Awaiting requested review from decsny

@dleach02 dleach02 Awaiting requested review from dleach02

@manuargue manuargue Awaiting requested review from manuargue

@mmahadevan108 mmahadevan108 Awaiting requested review from mmahadevan108

@nordic-auko nordic-auko Awaiting requested review from nordic-auko

@teburd teburd Awaiting requested review from teburd

@josuah josuah Awaiting requested review from josuah

@kartben kartben Awaiting requested review from kartben

@nashif nashif Awaiting requested review from nashif

Assignees

@tbursztyka tbursztyka

Labels

area: Boards/SoCs area: Devicetree Bindings area: MFD area: SPI SPI bus area: Tests Issues related to a particular existing or missing test platform: NXP Drivers NXP Semiconductors, drivers platform: NXP NXP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@zacck @pdgendt @kartben @tbursztyka @josuah @seov-nordic @cfriedt @zephyrbot