Skip to content

HDC302X - Add driver for this sensor #93718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

HDC302X - Add driver for this sensor #93718

wants to merge 2 commits into from

Conversation

StijnCoussement
Copy link

Add a driver for the TI HDC302X temperature and humidity sensor.
datasheet can be found on
https://cdn-learn.adafruit.com/assets/assets/000/131/097/original/hdc3021-q1.pdf?1720448563

@zephyrbot zephyrbot added area: Sensors Sensors platform: TI SimpleLink Texas Instruments SimpleLink MCU labels Jul 25, 2025
@pdgendt
Copy link
Contributor

pdgendt commented Jul 25, 2025

@StijnCoussement in the future, just force push to your existing PR instead of opening a new one, thanks!

@StijnCoussement
Copy link
Author

@pdgendt I'm very sorry for the new PR, something went wrong and Github closed previous one without notice.
I Might have done something wrong on my end while Squashing my commits.
Will be more careful next time...

pdgendt
pdgendt reviewed Jul 25, 2025
View reviewed changes
@pdgendt
Copy link
Contributor

pdgendt commented Jul 25, 2025

You should still need to cleanup your commits, look-up git interactive rebase if you're not familiar with the commands. You should end up with only 2 commits:

  1. Introduce new driver and bindings
  2. Added entry in tests

pdgendt
pdgendt reviewed Jul 25, 2025
View reviewed changes
Copy link
Contributor

@pdgendt pdgendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

;)

@StijnCoussement
Copy link
Author

I'm on leave after today so it is not urgent. I will pick this up on Monday august 18th. Thanks for the assistance so far.

@StijnCoussement StijnCoussement force-pushed the main branch 2 times, most recently from 406e909 to bbbd555 Compare July 25, 2025 14:28
@pdgendt
Copy link
Contributor

pdgendt commented Aug 18, 2025

Can you split the change in tests to its own commit? Thanks

@StijnCoussement
Copy link
Author

Can you split the change in tests to its own commit? Thanks

Is there a reason for this? just interested into why this would benefit anything...

@pdgendt
Copy link
Contributor

pdgendt commented Aug 18, 2025

Can you split the change in tests to its own commit? Thanks

Is there a reason for this? just interested into why this would benefit anything...

This is a contribution requirement:

  1. Distinct, Logical Units of Change

Each commit should correspond to a self-contained, meaningful change. For example, adding a feature, fixing a bug, or refactoring existing code should be separate commits. Avoid mixing different types of changes (e.g., feature implementation and unrelated refactoring) in the same commit.

@StijnCoussement
Copy link
Author

Can you split the change in tests to its own commit? Thanks

Is there a reason for this? just interested into why this would benefit anything...

This is a contribution requirement:

  1. Distinct, Logical Units of Change

Each commit should correspond to a self-contained, meaningful change. For example, adding a feature, fixing a bug, or refactoring existing code should be separate commits. Avoid mixing different types of changes (e.g., feature implementation and unrelated refactoring) in the same commit.

Oke I see, I didn't see that as different change as it does involves the same driver but I will split it up no problem.

pdgendt
pdgendt reviewed Aug 18, 2025
View reviewed changes
pdgendt
pdgendt reviewed Aug 18, 2025
View reviewed changes
MaureenHelm
MaureenHelm requested changes Aug 18, 2025
View reviewed changes
Copy link
Member

@MaureenHelm MaureenHelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

pdgendt
pdgendt reviewed Aug 19, 2025
View reviewed changes
pdgendt
pdgendt reviewed Aug 19, 2025
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@StijnCoussement
Copy link
Author

@pdgendt , @MaureenHelm ,

Thanks for your work already.
I wonder if there is anything still blocking the merge from my side?
I've made the requested changes but I'm not sure if the system reports that correctly.

Thanks

@zephyrbot zephyrbot added area: Tests Issues related to a particular existing or missing test area: Devicetree Bindings area: Boards/SoCs labels Oct 8, 2025
@zephyrbot zephyrbot requested a review from nashif October 8, 2025 07:55
@pdgendt
Copy link
Contributor

pdgendt commented Oct 8, 2025

No merge commits please, rebase your commits onto main.

@StijnCoussement
drivers: sensor: ti: Add TI temp sensor HDC302x
15c42ae 
The HDC302X sensor driver is added,
you can use this driver to read temperature and humidity.
Also set an offset, upper and lower limits to get warned
when temperature or humidity get out of band.
The sensor is build for ultra low power applications.

Signed-off-by: COUSSEMENT Stijn <[email protected]>
@StijnCoussement
drivers: sensor: ti: Add TI temp sensor HDC302x to tests
3b03b84 
The HDC302x sensor is added to the i2c tests

Signed-off-by: COUSSEMENT Stijn <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 9, 2025

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdgendt pdgendt pdgendt left review comments

@asemjonovs asemjonovs Awaiting requested review from asemjonovs

@avisconti avisconti Awaiting requested review from avisconti

@jeppenodgaard jeppenodgaard Awaiting requested review from jeppenodgaard

@teburd teburd Awaiting requested review from teburd

@tristan-google tristan-google Awaiting requested review from tristan-google

@ubieda ubieda Awaiting requested review from ubieda

@vaishnavachath vaishnavachath Awaiting requested review from vaishnavachath

@vanti vanti Awaiting requested review from vanti

@yperess yperess Awaiting requested review from yperess

@MaureenHelm MaureenHelm Awaiting requested review from MaureenHelm

@nashif nashif Awaiting requested review from nashif

Requested changes must be addressed to merge this pull request.

Assignees

@MaureenHelm MaureenHelm

Labels
area: Boards/SoCs area: Devicetree Bindings area: Sensors Sensors area: Tests Issues related to a particular existing or missing test platform: TI SimpleLink Texas Instruments SimpleLink MCU
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@StijnCoussement @pdgendt @MaureenHelm @zephyrbot