Skip to content

drivers: ethernet: eth_stm32 add tx async mode #93965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 20, 2025
+149 −23
Merged

drivers: ethernet: eth_stm32 add tx async mode #93965

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c2d77a7
drivers: ethernet: eth_stm32 tx_in_sem limit set to 1
Freey0 Oct 17, 2025
195a28b
drivers: ethernet: eth_stm32 add tx async mode
Freey0 Oct 17, 2025
4f06447
samples: zperf: Add STM32 eth_tx_async mode test
Freey0 Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion drivers/ethernet/eth_stm32_hal_v2.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,7 +512,7 @@ int eth_stm32_hal_init(const struct device *dev)
/* Initialize semaphores */
k_mutex_init(&dev_data->tx_mutex);
k_sem_init(&dev_data->rx_int_sem, 0, K_SEM_MAX_LIMIT);
k_sem_init(&dev_data->tx_int_sem, 0, K_SEM_MAX_LIMIT);
k_sem_init(&dev_data->tx_int_sem, 0, 1);
Comment on lines 514 to +608
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch and I think this error is widely spread in drivers.
Btw, are we sure rx_int_sem shouldn't also be used as a semaphore ? From the way it is used, I'd say yes.
If not maybe this is worth a comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whilst working on this PR, I hadn't paid attention to rx_int_sem. Having briefly examined its logic today, I'm not entirely certain whether counting is necessary, as it contains a loop. Testing will be required to ascertain this.


/* Tx config init: */
memset(&tx_config, 0, sizeof(ETH_TxPacketConfig));
Expand Down