drivers: ipm: esp32: properly handle send wait parameter #94021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: IPM
zephyrbot
requested review from
LucasTambor,
dcpleung,
marekmatej,
raffarost,
sylvioalves,
uLipe and
wmrsouza
dsseng
force-pushed
the
fix-esp32-ipm-wait
branch
from
7d4f135 to
870305d
Compare
uLipe
requested changes
Aug 2, 2025
dsseng
force-pushed
the
fix-esp32-ipm-wait
branch
from
870305d to
c2123eb
Compare
As clarified by the subsystem maintainers, wait should be treated as a boolean, not a duration. Signed-off-by: Dmitrii Sharshakov <[email protected]>
dsseng
force-pushed
the
fix-esp32-ipm-wait
branch
from
c2123eb to
7d068c4
Compare
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
uLipe
approved these changes
Aug 3, 2025
dcpleung
approved these changes
Aug 4, 2025
wmrsouza
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As clarified by the subsystem maintainers, wait should be treated as a
boolean, not a duration.
See #94020 and #92923 (comment) for clarifications.
This change has not been tested on the ESP32 platform, as I do not possess any boards. Please verify if necessary.
Signed-off-by: Dmitrii Sharshakov [email protected]