Skip to content

Conversation

djiatsaf-st
Copy link
Contributor

@djiatsaf-st djiatsaf-st commented Aug 4, 2025

This PR adds changes related to an issue observed in the I2S output test on the NUCLEO_U385RG_Q.

See here for more details : #92575 (comment)

required: zephyrproject-rtos/hal_stm32#301

@djiatsaf-st djiatsaf-st marked this pull request as draft August 4, 2025 14:33
@zephyrbot zephyrbot requested review from anangl, kartben and nashif August 4, 2025 14:34
Copy link

sonarqubecloud bot commented Aug 4, 2025

Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

required: zephyrproject-rtos/hal_stm32#301

Please update west.yaml if actually needed

@djiatsaf-st
Copy link
Contributor Author

Please update west.yaml if actually needed

Done

Copy link

github-actions bot commented Sep 15, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

erwango
erwango previously approved these changes Sep 15, 2025
Copy link
Contributor

@etienne-lms etienne-lms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but prefer with indentation issue fixed.

pinctrl-0 = <&sai1_mclk_a_pb8 &sai1_sd_a_pc1
&sai1_fs_a_pa9 &sai1_sck_a_pb10>;
pinctrl-0 = <&sai1_mclk_a_pb8 &sai1_sd_a_pc3
&sai1_fs_a_pb9 &sai1_sck_a_pb10>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indenation

	pinctrl-0 = <&sai1_mclk_a_pb8 &sai1_sd_a_pc3
		     &sai1_fs_a_pb9 &sai1_sck_a_pb10>;

or even:

	pinctrl-0 = <&sai1_mclk_a_pb8 &sai1_sd_a_pc3 &sai1_fs_a_pb9 &sai1_sck_a_pb10>;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Choose another sai1_fs_a pin available to avoid the need to
disable the Zephyr-chosen console and i2c3 node.

Signed-off-by: Fabrice DJIATSA <[email protected]>
Copy link

@anangl anangl assigned erwango and unassigned anangl Sep 19, 2025
@nashif nashif merged commit 5539a22 into zephyrproject-rtos:main Sep 19, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants