Skip to content

Add nxp edac driver #94111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add nxp edac driver #94111

wants to merge 3 commits into from
+716 −14

Conversation

yvesll
Copy link
Contributor

@yvesll yvesll commented Aug 5, 2025

Added NXP's EDAC implementation based on EIM and ERM

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2025

Hello @yvesll, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

decsny
decsny reviewed Aug 8, 2025
View reviewed changes
Copy link
Member

@decsny decsny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a very good first PR. But can you explain why this Devicetree structure with 4(+?) nodes was chosen?

@yvesll
Copy link
Contributor Author

yvesll commented Aug 9, 2025 •
edited
Loading

Looks like a very good first PR. But can you explain why this Devicetree structure with 4(+?) nodes was chosen?

You are correct, the virtual edac node and independent eim channel binding are redundant here.
I will only keep erm for error reporting and eim for error injection.

@yvesll yvesll force-pushed the add-nxp-edac-driver branch from e694c25 to be74c15 Compare August 11, 2025 07:27
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Holt-Sun
Holt-Sun reviewed Sep 16, 2025
View reviewed changes
@Holt-Sun
Copy link
Contributor

Quality Gate passed

Please fix the issue in "Quality Gate passed".

@yvesll yvesll force-pushed the add-nxp-edac-driver branch from be74c15 to 815fb39 Compare September 17, 2025 01:50
@zephyrbot zephyrbot requested a review from decsny September 17, 2025 01:51
@yvesll yvesll force-pushed the add-nxp-edac-driver branch from 815fb39 to 971b938 Compare September 18, 2025 07:32
decsny
decsny reviewed Sep 18, 2025
View reviewed changes
drivers/edac/edac_nxp.c Outdated
Comment on lines 31 to 37
#define EIM_CONFIG \
EIM_Type *eim_base; \
const struct edac_nxp_eim_channel *eim_channels; \
uint8_t eim_channel_num;
#else
#define EIM_CONFIG
#endif /* CONFIG_EDAC_ERROR_INJECT */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't need to be a macro, just #ifdef within the config struct definition, its actually less confusing that way

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's to avoid: https://github.com/zephyrproject-rtos/zephyr/actions/runs/17853922651/job/50768543249?pr=94111
Any suggestion to solve it in a more clear way?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@keith-zephyr I think the compliance script is doing something wrong here, I saw you are coding guideline maintainer, can you help figuring out what is the problem here? Because this code in the PR now is weird due to trying to get around this script, I guess

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checkpatch.pl is detecting the pointer * as a multiply operation instead of a pointer reference. I'm looking into checkpatch to figure out why checkpatch is running the operator checks on this line.

@yvesll yvesll force-pushed the add-nxp-edac-driver branch from 971b938 to 57d53c8 Compare September 19, 2025 09:10
@zephyrbot zephyrbot requested a review from decsny September 19, 2025 09:11
zejiang0jason
zejiang0jason reviewed Sep 29, 2025
View reviewed changes
yvesll added 3 commits October 9, 2025 15:17
@yvesll
drivers: edac: Add NXP EDAC driver
44ba5d4 
Add edac driver for NXP's ERM and EIM peripherals. It can inject ECC
error to specific channel within EIM and then report the error address,
syndrome and count within ERM.
Make the edac shell sample more generic for new platforms.

Signed-off-by: Yves Wang <[email protected]>
@yvesll
dts: add edac support for frdm_mcxa153 and frdm_mcxn236/947
e411a03 
Add eim, erm and edac instance for 3 nxp mcx boards

Signed-off-by: Yves Wang <[email protected]>
@yvesll
doc: Update edac shell sample's readme
84d39cd 
Update the console log in readme to make it aligned with the actual
output

Signed-off-by: Yves Wang <[email protected]>
@yvesll yvesll force-pushed the add-nxp-edac-driver branch from 57d53c8 to 84d39cd Compare October 9, 2025 07:46
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 9, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keith-zephyr keith-zephyr keith-zephyr left review comments

@bperseghetti bperseghetti Awaiting requested review from bperseghetti

@butok butok Awaiting requested review from butok

@dbaluta dbaluta Awaiting requested review from dbaluta

@DerekSnell DerekSnell Awaiting requested review from DerekSnell

@dleach02 dleach02 Awaiting requested review from dleach02

@EmilioCBen EmilioCBen Awaiting requested review from EmilioCBen

@finikorg finikorg Awaiting requested review from finikorg

@JiafeiPan JiafeiPan Awaiting requested review from JiafeiPan

@kartben kartben Awaiting requested review from kartben

@manuargue manuargue Awaiting requested review from manuargue

@MaochenWang1 MaochenWang1 Awaiting requested review from MaochenWang1

@mmahadevan108 mmahadevan108 Awaiting requested review from mmahadevan108

@nashif nashif Awaiting requested review from nashif

@PetervdPerk-NXP PetervdPerk-NXP Awaiting requested review from PetervdPerk-NXP

@decsny decsny Awaiting requested review from decsny

+2 more reviewers

@Holt-Sun Holt-Sun Holt-Sun left review comments

@zejiang0jason zejiang0jason zejiang0jason left review comments

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

@finikorg finikorg

Labels

area: Boards/SoCs area: Devicetree Bindings area: EDAC area: Samples Samples platform: NXP Drivers NXP Semiconductors, drivers platform: NXP MCU platform: NXP NXP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@yvesll @Holt-Sun @zejiang0jason @keith-zephyr @decsny @finikorg @zephyrbot