drivers: video: ov7670: update init regs

[mjs513]

While testing the OV7670 on the Arduino Giga using the ArduinoCore zephyr IDE I found that if:

{OV7670_COM10, 0x03}, /* COM10 */]

is not updated from

{OV7670_COM10, 0x20}, /* COM10 */

camera will start but no images will be shown.

I found this when looking at drivers: video: ov7670: Implement missing video API functions, controls and update init regs. it seems that only part of the PR was incorporated for the register changes requested?

[github-actions]

Hello @mjs513, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

[avolmat-st]

Thanks @mjs513 for the patch.
The update looks correct based on discussion I've seem in the other PR and the datasheet of the OV7670.
Free running PCLK should probably be the default and a non-continuous pclk should be requested via the related DT property (actually it isn't defined yet in the Zephyr video-interfaces.yaml, something that could be done in another PR if someone really need to enable non-continuous pclk mode).

I feel it is ok to update the value now, adding a proper comment on top of it to explain what this 0x03 does. Aka having VSYNC / HSYNC negative.
This driver should also (in another PR) be updated to rely on the endpoint and thus get those hsync / vsync / pclk polarity from the device-tree as for other drivers:

  hsync-active:
    type: int
    enum:
      - 0 # low
      - 1 # high
    description: |
      Active state of the HSYNC signal

  vsync-active:
    type: int
    enum:
      - 0 # low
      - 1 # high
    description: |
      Active state of the VSYNC signal.

  pclk-sample:
    type: int
    enum:
      - 0 # falling
      - 1 # rising
      - 2 # both
    description: |
      Sample data on falling, rising or both edges of the pixel clock signal.

There is currently 3 commits in this PR while I think there should be only 1 to update this COM10 value. Could you fix this and push an update ?

[avolmat-st]

I forget that there is also this PR #92645 which is on the same subject

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[mjs513]

Allcon - making this worse going to close this and reissue