-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Boards: Add Adafruit RP2040 Adalogger #94295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
boards/adafruit/feather_adalogger_rp2040/adafruit_feather_adalogger_rp2040-pinctrl.dtsi
Show resolved
Hide resolved
boards/adafruit/feather_adalogger_rp2040/adafruit_feather_adalogger_rp2040-pinctrl.dtsi
Outdated
Show resolved
Hide resolved
boards/adafruit/feather_adalogger_rp2040/adafruit_feather_adalogger_rp2040.dts
Outdated
Show resolved
Hide resolved
boards/adafruit/feather_adalogger_rp2040/adafruit_feather_adalogger_rp2040.dts
Outdated
Show resolved
Hide resolved
boards/adafruit/feather_adalogger_rp2040/adafruit_feather_adalogger_rp2040.dts
Show resolved
Hide resolved
boards/adafruit/feather_adalogger_rp2040/doc/img/feather_adalogger_rp2040.webp
Outdated
Show resolved
Hide resolved
Add the Adafruit RP2040 Adalogger board. The board image is from the Adafruit product page. Signed-off-by: Jonas Berg <[email protected]>
|
<17 0 &gpio0 10 0>, /* D10 */ | ||
<18 0 &gpio0 11 0>, /* D11 */ | ||
<19 0 &gpio0 12 0>, /* D12 */ | ||
<20 0 &gpio0 13 0>; /* D13 */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
excess spacing for this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes OK but please fix excess spacing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There doesn't seem to be any major problems.
@@ -0,0 +1,69 @@ | |||
#include <dt-bindings/pinctrl/rpi-pico-rp2040-pinctrl.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add SPDX-Identifier and copyrights notice.
color-mapping = <LED_COLOR_ID_GREEN | ||
LED_COLOR_ID_RED | ||
LED_COLOR_ID_BLUE>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please align start of symbol.
@@ -0,0 +1,12 @@ | |||
# SPDX-License-Identifier: Apache-2.0 | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add copyrights notice.
Add the Adafruit RP2040 Adalogger board.
The board image is from the Adafruit product page.