-
Notifications
You must be signed in to change notification settings - Fork 7.8k
samples: Bluetooth: Broadcast multiple legacy and extended advertising #94304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
cvinayak
wants to merge
3
commits into
zephyrproject-rtos:main
Choose a base branch
from
cvinayak:github_broadcast_multiple_with_legacy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
26 changes: 26 additions & 0 deletions
26
samples/bluetooth/broadcaster_multiple/overlay-bt_ll_sw_split.conf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
# Increased to 4 gives one each of legacy, 2M, 1M and Coded PHY advertising sets | ||
CONFIG_BT_EXT_ADV_MAX_ADV_SET=4 | ||
|
||
# Use Zephyr Bluetooth Low Energy Controller | ||
CONFIG_BT_LL_SW_SPLIT=y | ||
|
||
# Enable Coded PHY support in Zephyr Controller, if testing 4 advertising sets | ||
CONFIG_BT_CTLR_PHY_CODED=y | ||
|
||
# Zephyr Bluetooth LE Controller will need to use chain PDUs when AD data | ||
# length > 191 bytes | ||
# - 31 bytes will use 22 bytes for the default name in this sample plus 9 bytes | ||
# for manufacturer data | ||
# - 191 bytes will use 22 bytes for the default name in this sample plus 169 | ||
# bytes for manufacturer data | ||
# - 277 bytes will use 22 bytes for the default name in this sample plus 255 | ||
# bytes for manufacturer data | ||
CONFIG_BT_CTLR_ADV_DATA_LEN_MAX=192 | ||
|
||
# Increase Advertising PDU buffers to number of advertising sets times the | ||
# number of chain PDUs per advertising set when using Zephyr Bluetooth LE | ||
# Controller | ||
CONFIG_BT_CTLR_ADVANCED_FEATURES=y | ||
CONFIG_BT_CTLR_ADV_RESERVE_MAX=n | ||
CONFIG_BT_CTLR_ADV_DATA_BUF_MAX=6 | ||
CONFIG_BT_CTLR_ADV_DATA_CHAIN=y |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,23 +1,10 @@ | ||
CONFIG_BT=y | ||
CONFIG_BT_BROADCASTER=y | ||
CONFIG_BT_EXT_ADV=y | ||
CONFIG_BT_EXT_ADV_MAX_ADV_SET=2 | ||
CONFIG_BT_DEVICE_NAME="Broadcaster Multiple" | ||
|
||
CONFIG_LOG=y | ||
|
||
# Zephyr Bluetooth LE Controller will need to use chain PDUs when AD data | ||
# length > 191 bytes | ||
# - 31 bytes will use 22 bytes for the default name in this sample plus 9 bytes | ||
# for manufacturer data | ||
# - 191 bytes will use 22 bytes for the default name in this sample plus 169 | ||
# bytes for manufacturer data | ||
# - 277 bytes will use 22 bytes for the default name in this sample plus 255 | ||
# bytes for manufacturer data | ||
# CONFIG_BT_CTLR_ADV_DATA_LEN_MAX=192 | ||
# Require Bluetooth Advertising Extensions Feature | ||
CONFIG_BT_EXT_ADV=y | ||
|
||
# Increase Advertising PDU buffers to number of advertising sets times the | ||
# number of chain PDUs per advertising set when using Zephyr Bluetooth LE | ||
# Controller | ||
# CONFIG_BT_CTLR_ADVANCED_FEATURES=y | ||
# CONFIG_BT_CTLR_ADV_DATA_BUF_MAX=2 | ||
# Increased to 4 gives one each of legacy, 2M, 1M and Coded PHY advertising sets | ||
CONFIG_BT_EXT_ADV_MAX_ADV_SET=2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,24 @@ | ||
sample: | ||
name: Bluetooth Multiple Extended Advertising Broadcaster | ||
tests: | ||
sample.bluetooth.multiple_broadcast: | ||
sample.bluetooth.broadcaster_multiple: | ||
harness: bluetooth | ||
tags: bluetooth | ||
platform_allow: | ||
- qemu_cortex_m3 | ||
- qemu_x86 | ||
integration_platforms: | ||
- qemu_cortex_m3 | ||
sample.bluetooth.broadcaster_multiple.bt_ll_sw_split: | ||
harness: bluetooth | ||
tags: bluetooth | ||
extra_args: | ||
- EXTRA_CONF_FILE=overlay-bt_ll_sw_split.conf | ||
platform_allow: | ||
- nrf51dk/nrf51822 | ||
- nrf52_bsim | ||
- nrf52dk/nrf52832 | ||
tags: bluetooth | ||
- nrf52840dk/nrf52840 | ||
integration_platforms: | ||
- qemu_cortex_m3 | ||
- nrf52dk/nrf52832 | ||
- nrf52840dk/nrf52840 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't look like it's following a correct indentation style, where the contents of a new
{ ... }
block should always be indented by one more tab. If you did it like the following it should be correct, and not even add any new lines:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, will fix this indentation.