Skip to content

Misc SSD1327 and SSD1363 improvements #94316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Misc SSD1327 and SSD1363 improvements #94316

wants to merge 3 commits into from
+29 −27

Conversation

VynDragon
Copy link
Contributor

greyscale -> grayscale
+const
ssd1363 lut -> ssd1327 style lut

@VynDragon
drivers: display: ssd1327: lut table as const
13eaf1f 
LUT table to rom instead of ram

Signed-off-by: Camille BAUD <[email protected]>
@VynDragon VynDragon requested review from JarmouniA and josuah August 11, 2025 06:28
josuah
josuah previously approved these changes Aug 11, 2025
View reviewed changes
Copy link
Contributor

@josuah josuah left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code quality goes up again for SSDxxx drivers!

@VynDragon
drivers: display: greyscale -> grayscale for ssd1363
e30f476 
british english -> american english

Signed-off-by: Camille BAUD <[email protected]>
@VynDragon
drivers: display: improve LUT table for ssd1363
4682641 
Model on ssd1327

Signed-off-by: Camille BAUD <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
14.3% Duplication on New Code

See analysis details on SonarQube Cloud

danieldegrasse
danieldegrasse reviewed Aug 11, 2025
View reviewed changes
Copy link
Contributor

@danieldegrasse danieldegrasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem with changing grey-> gray, but do we have any documentation on the preferred spelling? Both are correct.

If we are changing property names, we should add this to the migration guide.

@VynDragon
Copy link
Contributor Author

No problem with changing grey-> gray, but do we have any documentation on the preferred spelling? Both are correct.

If we are changing property names, we should add this to the migration guide.

Yes #87921 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldegrasse danieldegrasse danieldegrasse left review comments

@josuah josuah josuah approved these changes

@JarmouniA JarmouniA JarmouniA approved these changes

@jfischer-no jfischer-no Awaiting requested review from jfischer-no

Assignees
No one assigned
Labels
area: Display
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@VynDragon @danieldegrasse @JarmouniA @josuah @zephyrbot