-
Notifications
You must be signed in to change notification settings - Fork 7.8k
mimxrt798s: Revert GPIO0 support for HiFi 4 #94321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
VitekST
wants to merge
4
commits into
zephyrproject-rtos:main
Choose a base branch
from
nxp-upstream:bugfix/94315-rt700-gpio0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
mimxrt798s: Revert GPIO0 support for HiFi 4 #94321
VitekST
wants to merge
4
commits into
zephyrproject-rtos:main
from
nxp-upstream:bugfix/94315-rt700-gpio0
+15
−76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eda6c7f
to
44ef33b
Compare
44ef33b
to
8cb45c9
Compare
Add a build error conditional for mimxrt700_evk/mimxrt798s/cm33_cpu0, thus disabling build for the hifi4 domain. Remove that target from platform_allow in sample.yaml. Signed-off-by: Vit Stanicek <[email protected]>
Remove overlay of gpio0 node. Remove dependent nodes (LEDs, keys). Remove alias bindings of those. Signed-off-by: Vit Stanicek <[email protected]>
Remove INPUTMUX interrupt assignments for PINT and GPIO peripherals. Remove gpio0 DT node. As the GPIO peripherals can be secured on the mimxrt798s, accesses from the cm33_cpu0 and hifi4 are mutually exclusive, so the GPIO0 will stay enabled in the cm33_cpu0 domain. Signed-off-by: Vit Stanicek <[email protected]>
This reverts commit 40f0842. The PCNS and ICNS registers of the mimxrt798s's GPIO0 peripheral allow accesses to be set up only with mutual exclusivity (either the cm33_cpu0 or the hifi4), thus the access is reverted to the cm33_cpu0 domain. Signed-off-by: Vit Stanicek <[email protected]>
8cb45c9
to
06fb8ca
Compare
|
dcpleung
approved these changes
Aug 11, 2025
iuliana-prodan
approved these changes
Aug 11, 2025
decsny
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the access level registers for GPIO peripherals on
mimxrt798s
are mutually exclusive (in this case, they allow the peripheral to be used in only one ofcm33_cpu0
andhifi4
), this PR ditches GPIO0 support onmimxrt798s/hifi4
entirely in favour of using that peripheral on thecm33_cpu0
domain only.Fixes #94315.